Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1239963004: Settings Rewrite: Morph old MD-Settings to Basic and Advanced menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/common/url_constants.h" 8 #include "chrome/common/url_constants.h"
9 #include "chrome/grit/chromium_strings.h" 9 #include "chrome/grit/chromium_strings.h"
10 #include "chrome/grit/generated_resources.h" 10 #include "chrome/grit/generated_resources.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 html_source->AddLocalizedString( 54 html_source->AddLocalizedString(
55 "delayBeforeClickShort", IDS_SETTINGS_DELAY_BEFORE_CLICK_SHORT); 55 "delayBeforeClickShort", IDS_SETTINGS_DELAY_BEFORE_CLICK_SHORT);
56 html_source->AddLocalizedString( 56 html_source->AddLocalizedString(
57 "delayBeforeClickLong", IDS_SETTINGS_DELAY_BEFORE_CLICK_LONG); 57 "delayBeforeClickLong", IDS_SETTINGS_DELAY_BEFORE_CLICK_LONG);
58 html_source->AddLocalizedString( 58 html_source->AddLocalizedString(
59 "delayBeforeClickVeryLong", IDS_SETTINGS_DELAY_BEFORE_CLICK_VERY_LONG); 59 "delayBeforeClickVeryLong", IDS_SETTINGS_DELAY_BEFORE_CLICK_VERY_LONG);
60 html_source->AddLocalizedString( 60 html_source->AddLocalizedString(
61 "onScreenKeyboardLabel", IDS_SETTINGS_ON_SCREEN_KEYBOARD_LABEL); 61 "onScreenKeyboardLabel", IDS_SETTINGS_ON_SCREEN_KEYBOARD_LABEL);
62 } 62 }
63 63
64 void AddAdvancedStrings(content::WebUIDataSource* html_source) {
65 html_source->AddLocalizedString("advancedPageTitle",
michaelpg 2015/07/20 21:23:10 We don't anticipate more strings than this, do we?
tommycli 2015/07/20 22:58:58 Done.
66 IDS_SETTINGS_ADVANCED_PAGE_TITLE);
67 }
68
64 void AddAppearanceStrings(content::WebUIDataSource* html_source) { 69 void AddAppearanceStrings(content::WebUIDataSource* html_source) {
65 html_source->AddLocalizedString( 70 html_source->AddLocalizedString(
66 "appearancePageTitle", IDS_SETTINGS_APPEARANCE_PAGE_TITLE); 71 "appearancePageTitle", IDS_SETTINGS_APPEARANCE_PAGE_TITLE);
67 html_source->AddLocalizedString( 72 html_source->AddLocalizedString(
68 "setWallpaper", IDS_SETTINGS_SET_WALLPAPER); 73 "setWallpaper", IDS_SETTINGS_SET_WALLPAPER);
69 html_source->AddLocalizedString( 74 html_source->AddLocalizedString(
70 "getThemes", IDS_SETTINGS_GET_THEMES); 75 "getThemes", IDS_SETTINGS_GET_THEMES);
71 html_source->AddLocalizedString( 76 html_source->AddLocalizedString(
72 "resetToDefaultTheme", IDS_SETTINGS_RESET_TO_DEFAULT_THEME); 77 "resetToDefaultTheme", IDS_SETTINGS_RESET_TO_DEFAULT_THEME);
73 html_source->AddLocalizedString( 78 html_source->AddLocalizedString(
74 "showHomeButton", IDS_SETTINGS_SHOW_HOME_BUTTON); 79 "showHomeButton", IDS_SETTINGS_SHOW_HOME_BUTTON);
75 html_source->AddLocalizedString( 80 html_source->AddLocalizedString(
76 "showBookmarksBar", IDS_SETTINGS_SHOW_BOOKMARKS_BAR); 81 "showBookmarksBar", IDS_SETTINGS_SHOW_BOOKMARKS_BAR);
77 html_source->AddLocalizedString( 82 html_source->AddLocalizedString(
78 "homePageNtp", IDS_SETTINGS_HOME_PAGE_NTP); 83 "homePageNtp", IDS_SETTINGS_HOME_PAGE_NTP);
79 html_source->AddLocalizedString( 84 html_source->AddLocalizedString(
80 "changeHomePage", IDS_SETTINGS_CHANGE_HOME_PAGE); 85 "changeHomePage", IDS_SETTINGS_CHANGE_HOME_PAGE);
81 html_source->AddLocalizedString( 86 html_source->AddLocalizedString(
82 "themesGalleryUrl", IDS_THEMES_GALLERY_URL); 87 "themesGalleryUrl", IDS_THEMES_GALLERY_URL);
83 } 88 }
84 89
90 void AddBasicStrings(content::WebUIDataSource* html_source) {
91 html_source->AddLocalizedString("basicPageTitle",
92 IDS_SETTINGS_BASIC_PAGE_TITLE);
93 }
94
85 void AddCommonStrings(content::WebUIDataSource* html_source) { 95 void AddCommonStrings(content::WebUIDataSource* html_source) {
86 html_source->AddLocalizedString("addLabel", IDS_ADD); 96 html_source->AddLocalizedString("addLabel", IDS_ADD);
87 } 97 }
88 98
89 void AddDownloadsStrings(content::WebUIDataSource* html_source) { 99 void AddDownloadsStrings(content::WebUIDataSource* html_source) {
90 html_source->AddLocalizedString( 100 html_source->AddLocalizedString(
91 "downloadsPageTitle", IDS_SETTINGS_DOWNLOADS_PAGE_TITLE); 101 "downloadsPageTitle", IDS_SETTINGS_DOWNLOADS_PAGE_TITLE);
92 html_source->AddLocalizedString( 102 html_source->AddLocalizedString(
93 "downloadLocation", IDS_SETTINGS_DOWNLOAD_LOCATION); 103 "downloadLocation", IDS_SETTINGS_DOWNLOAD_LOCATION);
94 html_source->AddLocalizedString( 104 html_source->AddLocalizedString(
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 html_source->AddLocalizedString("addUsersLabel", 266 html_source->AddLocalizedString("addUsersLabel",
257 IDS_SETTINGS_USERS_ADD_USERS_LABEL); 267 IDS_SETTINGS_USERS_ADD_USERS_LABEL);
258 } 268 }
259 269
260 } // namespace 270 } // namespace
261 271
262 namespace settings { 272 namespace settings {
263 273
264 void AddLocalizedStrings(content::WebUIDataSource* html_source) { 274 void AddLocalizedStrings(content::WebUIDataSource* html_source) {
265 AddA11yStrings(html_source); 275 AddA11yStrings(html_source);
276 AddAdvancedStrings(html_source);
266 AddAppearanceStrings(html_source); 277 AddAppearanceStrings(html_source);
278 AddBasicStrings(html_source);
267 AddCommonStrings(html_source); 279 AddCommonStrings(html_source);
268 AddDownloadsStrings(html_source); 280 AddDownloadsStrings(html_source);
269 AddDateTimeStrings(html_source); 281 AddDateTimeStrings(html_source);
270 #if defined(OS_CHROMEOS) 282 #if defined(OS_CHROMEOS)
271 AddInternetStrings(html_source); 283 AddInternetStrings(html_source);
272 #endif 284 #endif
273 AddPrivacyStrings(html_source); 285 AddPrivacyStrings(html_source);
274 AddSearchStrings(html_source); 286 AddSearchStrings(html_source);
275 AddSearchEnginesStrings(html_source); 287 AddSearchEnginesStrings(html_source);
276 AddSyncStrings(html_source); 288 AddSyncStrings(html_source);
277 AddUsersStrings(html_source); 289 AddUsersStrings(html_source);
278 html_source->SetJsonPath(kLocalizedStringsFile); 290 html_source->SetJsonPath(kLocalizedStringsFile);
279 } 291 }
280 292
281 } // namespace settings 293 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698