Settings Rewrite: Morph old MD-Settings to Basic and Advanced menu.

Settings Rewrite: Morph old MD-Settings to Basic and Advanced menu.

This patch takes the old MD Settings work, and changes it to closer match the UI
approved mocks, which divide the settings into Basic and Advanced.

The previous subsections are now all scrollable within the Basic and Advanced
sections.

This also removes the user badge that has been removed from the mocks.

BUG=
TBR=
TBR for GRD changes only. Other changes reviewed.

Committed: https://crrev.com/a8503a9214ea68f44e462cc32b9e79c001c13b7d
Cr-Commit-Position: refs/heads/master@{#339692}

[tommycli, 2015-07-16 20:08:56]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2015-07-16 20:08:56]

dbeam: ptal, these are the changes to make a basic and advanced page as we
discussed yesterday.

tommy

[Dan Beam, 2015-07-18 00:54:46]

dbeam@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Dan Beam, 2015-07-18 00:54:47]

michaelpg@ is a better review for this as he's seen (or written) this code and I
haven't

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.css (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.css:3: * found in
the LICENSE file. */
hmmm

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.html:13: <if
expr="chromeos">
is this page grit processed?

[tommycli, 2015-07-20 21:02:16]

dbeam: thanks

michaelpg: PTAL, thanks!

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.css (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.css:3: * found in
the LICENSE file. */
On 2015/07/18 00:54:46, Dan Beam wrote:
> hmmm

Done.

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.html:13: <if
expr="chromeos">
On 2015/07/18 00:54:47, Dan Beam wrote:
> is this page grit processed?

Yes. I think so. This was taken out of settings_main.html and placed here. They
both are in settings_resources.grd.

[michaelpg, 2015-07-20 21:23:10]

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/routes.html (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/routes.html:12: <more-route name="basic"
path="/basic"></more-route>
maybe just path="/" to make this the default?

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.html (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.html:26:
<cr-settings-internet-detail-page route="internet-detail"
There's something weird about having all the top-level pages within
<cr-settings-{basic,advanced}-page>, and then having the subpages here as
siblings to <cr-settings-{basic,advanced}-page>.

I haven't come up with a more intuitive solution that's as simple as this, but I
reserve the right to refactor in the future :-)

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:65:
html_source->AddLocalizedString("advancedPageTitle",
We don't anticipate more strings than this, do we? These two new functions seem
unnecessary.

[tommycli, 2015-07-20 22:58:58]

michaelpg: thanks, let me know if this is better

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/routes.html (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/routes.html:12: <more-route name="basic"
path="/basic"></more-route>
On 2015/07/20 21:23:10, michaelpg wrote:
> maybe just path="/" to make this the default?

Done.

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.html (right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.html:26:
<cr-settings-internet-detail-page route="internet-detail"
On 2015/07/20 21:23:10, michaelpg wrote:
> There's something weird about having all the top-level pages within
> <cr-settings-{basic,advanced}-page>, and then having the subpages here as
> siblings to <cr-settings-{basic,advanced}-page>.
> 
> I haven't come up with a more intuitive solution that's as simple as this, but
I
> reserve the right to refactor in the future :-)

Acknowledged.

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1239963004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:65:
html_source->AddLocalizedString("advancedPageTitle",
On 2015/07/20 21:23:10, michaelpg wrote:
> We don't anticipate more strings than this, do we? These two new functions
seem
> unnecessary.

Done.

[tommycli, 2015-07-20 22:59:15]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 22:59:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239963004/60001

[michaelpg, 2015-07-20 23:03:10]

lgtm

[tommycli, 2015-07-20 23:14:34]

tommycli@chromium.org changed reviewers:
+ cpu@chromium.org

[tommycli, 2015-07-20 23:14:34]

cpu: may i have a review of chrome/app/settings_strings.grdp please, thanks!

[commit-bot: I haz the power, 2015-07-21 00:02:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 00:02:02]

Dry run: This issue passed the CQ dry run.

[cpu_(ooo_6.6-7.5), 2015-07-21 17:47:26]

grd changes by committers are tbr=

[tommycli, 2015-07-21 17:49:11]

TBR=
TBR for GRD changes only. Other changes reviewed.

[tommycli, 2015-07-21 17:50:24]

cpu: okay thanks!

[tommycli, 2015-07-21 17:50:33]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-07-21 17:51:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239963004/60001

[commit-bot: I haz the power, 2015-07-21 17:57:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-21 17:58:44]

Patchset 4 (id:??) landed as
https://crrev.com/a8503a9214ea68f44e462cc32b9e79c001c13b7d
Cr-Commit-Position: refs/heads/master@{#339692}