Allow Srcs to veto Sinks based on their broad type.

Allow Srcs to veto Sinks based on their broad type.

This breaks Sinks down into three auto-detected types:
  - GPU:    anything that requests to be run in the GPU enclave
  - Vector: anything that writes to the stream instead of the bitmap
  - Raster: everything else

Some examples: gpu -> GPU, msaa16 -> GPU, 8888 -> raster, pdf -> vector,
               svg -> vector, pipe-8888 -> raster, tiles_rt-gpu -> GPU

This lets image decoding sinks veto non-raster backends explicitly,
and can let particular GMs veto GPU or non-GPU sinks as they like.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/e0effd60800bd7c07667e31a6a66e3def8de70c8

[mtklein_C, 2015-07-17 13:53:54]

mtklein@chromium.org changed reviewers:
+ caryclark@google.com, scroggo@google.com

[mtklein_C, 2015-07-17 13:53:54]

mtklein@chromium.org changed required reviewers:
+ caryclark@google.com, scroggo@google.com

[mtklein_C, 2015-07-17 13:53:55]

What do you guys think?

Seems like we've got multiple use cases for a Src/Sink pair to negotiate whether
they're going to run.

[scroggo, 2015-07-17 14:10:48]

lgtm

Should this CL include changes to the blacklist, where they're no longer
necessary?

https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp#newcode82
dm/DMSrcSink.cpp:82: SkImageInfo canvasInfo = canvas->imageInfo();
nit: We now only use canvasInfo once, down below. We could remove this line, and
make the below say

SkColorType = canvas->imageInfo().colorType();

https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp#newcode400
dm/DMSrcSink.cpp:400: const SkColorType dstColorType = canvasInfo.colorType();
Again, canvasInfo is not needed as its own variable (only referenced once).

[mtklein, 2015-07-17 14:22:26]

On 2015/07/17 14:10:48, scroggo wrote:
> lgtm
> 
> Should this CL include changes to the blacklist, where they're no longer
> necessary?
> 
> https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp
> File dm/DMSrcSink.cpp (right):
> 
> https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp#newcode82
> dm/DMSrcSink.cpp:82: SkImageInfo canvasInfo = canvas->imageInfo();
> nit: We now only use canvasInfo once, down below. We could remove this line,
and
> make the below say
> 
> SkColorType = canvas->imageInfo().colorType();
> 
> https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp#newcode400
> dm/DMSrcSink.cpp:400: const SkColorType dstColorType = canvasInfo.colorType();
> Again, canvasInfo is not needed as its own variable (only referenced once).

Done, ptal.

[scroggo, 2015-07-17 15:08:33]

On 2015/07/17 14:22:26, mtklein wrote:
> On 2015/07/17 14:10:48, scroggo wrote:
> > lgtm
> > 
> > Should this CL include changes to the blacklist, where they're no longer
> > necessary?
> > 
> > https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp
> > File dm/DMSrcSink.cpp (right):
> > 
> > https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp#newcode82
> > dm/DMSrcSink.cpp:82: SkImageInfo canvasInfo = canvas->imageInfo();
> > nit: We now only use canvasInfo once, down below. We could remove this line,
> and
> > make the below say
> > 
> > SkColorType = canvas->imageInfo().colorType();
> > 
> >
https://codereview.chromium.org/1239953004/diff/1/dm/DMSrcSink.cpp#newcode400
> > dm/DMSrcSink.cpp:400: const SkColorType dstColorType =
canvasInfo.colorType();
> > Again, canvasInfo is not needed as its own variable (only referenced once).
> 
> Done, ptal.

LGTM

[mtklein, 2015-07-29 13:29:17]

mtklein@google.com changed reviewers:
+ scroggo@chromium.org
- caryclark@google.com, scroggo@google.com

[mtklein, 2015-07-29 13:29:18]

mtklein@google.com changed required reviewers:
+ scroggo@chromium.org
- caryclark@google.com, scroggo@google.com

[mtklein, 2015-07-29 13:29:23]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-07-29 13:29:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239953004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1239953004/20001

[commit-bot: I haz the power, 2015-07-29 13:29:32]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-07-29 19:29 UTC

[scroggo, 2015-07-29 13:31:10]

On 2015/07/29 13:29:32, commit-bot: I haz the power wrote:
> Note for Reviewers:
> The CQ is waiting for an approval.
> If you believe that the CL is not ready yet, or if you would like to L-G-T-M
> with comments then please uncheck the CQ checkbox.
> 
> Waiting for LGTM from valid reviewer(s) till 2015-07-29 19:29 UTC

Am I no longer a valid reviewer?? LGTM again...

[mtklein, 2015-07-29 13:31:13]

mtklein@google.com changed reviewers:
+ scroggo@google.com
- mtklein@google.com, scroggo@chromium.org

[mtklein, 2015-07-29 13:31:13]

mtklein@google.com changed required reviewers:
- scroggo@chromium.org

[mtklein, 2015-07-29 13:31:38]

On 2015/07/29 13:31:10, scroggo wrote:
> On 2015/07/29 13:29:32, commit-bot: I haz the power wrote:
> > Note for Reviewers:
> > The CQ is waiting for an approval.
> > If you believe that the CL is not ready yet, or if you would like to L-G-T-M
> > with comments then please uncheck the CQ checkbox.
> > 
> > Waiting for LGTM from valid reviewer(s) till 2015-07-29 19:29 UTC
> 
> Am I no longer a valid reviewer?? LGTM again...

I think I had your Chromium twin listed as required reviewer...

[mtklein, 2015-07-29 13:31:42]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-07-29 13:31:46]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-07-29 13:31:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239953004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1239953004/20001

[commit-bot: I haz the power, 2015-07-29 13:37:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e0effd60800bd7c07667e31a6a66e3def8de70c8