Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4260)

Unified Diff: chrome/android/java/res/layout/webapp_splashscreen.xml

Issue 1239923002: webapps: add splashscreen for installed webapps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest-title
Patch Set: Fix compile and remove scaling Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/webapp_splashscreen.xml
diff --git a/chrome/android/java/res/layout/webapp_splashscreen.xml b/chrome/android/java/res/layout/webapp_splashscreen.xml
index d90c66066a77d9837d1d3875107604eca375abd3..4f7b95219f2bf5972697429a3c0157cbaa0b6bb3 100644
--- a/chrome/android/java/res/layout/webapp_splashscreen.xml
+++ b/chrome/android/java/res/layout/webapp_splashscreen.xml
@@ -7,5 +7,20 @@
-->
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
- android:layout_height="match_parent"
- android:orientation="vertical" />
+ android:layout_height="match_parent" >
+
+ <ImageView
+ android:id="@+id/webapp_splashscreen_icon"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_gravity="center"
+ android:contentDescription="@null" />
+
+ <TextView
+ android:id="@+id/webapp_splashscreen_name"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_gravity="bottom|center_horizontal"
+ android:textAppearance="@style/WebAppSplashScreenTextAppearanceTitle"
gone 2015/09/04 18:25:55 nit: group the layout_ attributes together instead
newt (away) 2015/09/04 18:45:48 Since you're only using this style in one place, I
Lalit Maganti 2015/09/04 19:12:02 Done both.
+ android:layout_marginBottom="@dimen/webapp_splash_title_bottom_margin" />
+</FrameLayout>
« no previous file with comments | « no previous file | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/res/values/colors.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698