chrome/android/java/res/layout/webapp_splashscreen.xml - Issue 1239923002: webapps: add splashscreen for installed webapps

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/webapp_splashscreen.xml

Issue 1239923002: webapps: add splashscreen for installed webapps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest-title

Patch Set: Fix compile and remove scaling Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!--	2 <!--

3 Copyright 2015 The Chromium Authors. All rights reserved.	3 Copyright 2015 The Chromium Authors. All rights reserved.

4	4

5 Use of this source code is governed by a BSD-style license that can be	5 Use of this source code is governed by a BSD-style license that can be

6 found in the LICENSE file.	6 found in the LICENSE file.

7 -->	7 -->

8 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"	8 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

9 android:layout_width="match_parent"	9 android:layout_width="match_parent"

10 android:layout_height="match_parent"	10 android:layout_height="match_parent" >

11 android:orientation="vertical" />	11

	12 <ImageView

	13 android:id="@+id/webapp_splashscreen_icon"

	14 android:layout_width="wrap_content"

	15 android:layout_height="wrap_content"

	16 android:layout_gravity="center"

	17 android:contentDescription="@null" />

	18

	19 <TextView

	20 android:id="@+id/webapp_splashscreen_name"

	21 android:layout_width="wrap_content"

	22 android:layout_height="wrap_content"

	23 android:layout_gravity="bottom\|center_horizontal"

	24 android:textAppearance="@style/WebAppSplashScreenTextAppearanceTitle"
	gone 2015/09/04 18:25:55 nit: group the layout_ attributes together instead nit: group the layout_ attributes together instead of putting textAppearance in the middle newt (away) 2015/09/04 18:45:48 Since you're only using this style in one place, I Since you're only using this style in one place, I wouldn't use a style at all. Just add android:fontFamily, android:textSize, and android:textColor attributes directly to this TextView. Lalit Maganti 2015/09/04 19:12:02 Done both. Show quoted text On 2015/09/04 18:45:48, newt wrote: > Since you're only using this style in one place, I wouldn't use a style at all. > Just add android:fontFamily, android:textSize, and android:textColor attributes > directly to this TextView. Done both.
	25 android:layout_marginBottom="@dimen/webapp_splash_title_bottom_margin" / >

	26 </FrameLayout>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/res/values/colors.xml » ('J')