Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1239703003: Revert of Enable proguarding the WebView APK. (Closed)

Created:
5 years, 5 months ago by Yusuf
Modified:
5 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable proguarding the WebView APK. (patchset #1 id:1 of https://codereview.chromium.org/1226813002/) Reason for revert: Broke release builds downstream. crbug.com/510625 Original issue's description: > Enable proguarding the WebView APK. > > Proguard was disabled for WebView as the configuration was out of date. > Re-enable it now the configuration has been updated. > > BUG=442348 > > Committed: https://crrev.com/edefec8e457e96dcfa7251f7fadfa24605f8a9fb > Cr-Commit-Position: refs/heads/master@{#338856} TBR=sgurun@chromium.org,torne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=442348 Committed: https://crrev.com/ec01d66d89981e78236f810807ba07d23a47d64b Cr-Commit-Position: refs/heads/master@{#338941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/apk/system_webview_apk_common.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuf
Created Revert of Enable proguarding the WebView APK.
5 years, 5 months ago (2015-07-15 22:41:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239703003/1
5 years, 5 months ago (2015-07-15 22:42:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 22:43:29 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 22:44:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec01d66d89981e78236f810807ba07d23a47d64b
Cr-Commit-Position: refs/heads/master@{#338941}

Powered by Google App Engine
This is Rietveld 408576698