android_webview/apk/system_webview_apk_common.gypi - Issue 1239703003: Revert of Enable proguarding the WebView APK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/apk/system_webview_apk_common.gypi

Issue 1239703003: Revert of Enable proguarding the WebView APK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/apk/system_webview_apk_common.gypi

diff --git a/android_webview/apk/system_webview_apk_common.gypi b/android_webview/apk/system_webview_apk_common.gypi

index a777c10a6be83562ea5b367cbb02b53bdb2da7db..9739ae0b781196c911d652bb351a6286d67c335b 100644

--- a/android_webview/apk/system_webview_apk_common.gypi

+++ b/android_webview/apk/system_webview_apk_common.gypi

@@ -26,7 +26,8 @@

'android_manifest_template_vars': [ ],

'android_manifest_template_path': '<(DEPTH)/android_webview/apk/java/AndroidManifest.xml',

'android_manifest_path': '<(jinja_output)',

- 'proguard_enabled': 'true',

+ # TODO: crbug.com/442348 Update proguard.flags and re-enable.

+ 'proguard_enabled': 'false',

'proguard_flags_paths': ['<(DEPTH)/android_webview/apk/java/proguard.flags'],

# TODO: crbug.com/405035 Find a better solution for WebView .pak files.

'additional_input_paths': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »