chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "may not be -1" -> "may be -1" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc ('K') | « chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc ('k') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('j') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc

index e453f32e73bf1df33e767f0a2066ba9856ae534b..6326aae5863f3135a8baa282cb105ca3dea46c8d 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc

@@ -84,6 +84,7 @@ scoped_ptr<tabs::Tab> CreateTabModelHelper(

const GURL& url = current_navigation.virtual_url();

std::string title = base::UTF16ToUTF8(current_navigation.title());

+ tab_struct->id = -1;

tab_struct->session_id.reset(new std::string(session_id));

tab_struct->url.reset(new std::string(url.spec()));

tab_struct->fav_icon_url.reset(