chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc - Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "may not be -1" -> "may be -1" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

index 6fa89dda112ea77462bdb97af4796e09604e4025..622f2616f9d567f5c63184de2b1a0a886447918c 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

@@ -74,12 +74,12 @@ bool DesktopCaptureChooseDesktopMediaFunction::RunAsync() {

target_name = base::UTF8ToUTF16(content::IsOriginSecure(origin) ?

net::GetHostAndOptionalPort(origin) : origin.spec());

- if (!params->target_tab->id) {

+ if (params->target_tab->id < 0) {

not at google - send to devlin 2015/07/16 17:09:23 See TAB_ID_NONE comment.

llandwerlin-old 2015/07/17 11:32:04 Done.

error_ = kNoTabIdError;

return false;

}

- if (!ExtensionTabUtil::GetTabById(*(params->target_tab->id), GetProfile(),

+ if (!ExtensionTabUtil::GetTabById(params->target_tab->id, GetProfile(),

true, NULL, NULL, &web_contents, NULL)) {

error_ = kInvalidTabIdError;

return false;

« no previous file with comments | « no previous file | chrome/browser/extensions/api/sessions/sessions_api.cc » ('j') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('J')