Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1239633002: Remove //sky/engine/platform/network (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, jackson_old, gregsimon, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove //sky/engine/platform/network This code is all dead. Instead, we use Mojo directly from Dart to access the network. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/cc602f4efa7bf5981d71c93eaf6720cb32417d9b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7216 lines) Patch
M services/sky/document_view.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M services/sky/viewer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameConsole.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/FrameConsole.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/loader/FrameLoaderClient.h View 4 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/testing/URLTestHelpers.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 3 chunks +0 lines, -34 lines 0 comments Download
D sky/engine/platform/exported/WebHTTPBody.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
D sky/engine/platform/exported/WebHTTPLoadInfo.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
D sky/engine/platform/exported/WebURLError.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/engine/platform/exported/WebURLLoadTiming.cpp View 1 chunk +0 lines, -189 lines 0 comments Download
D sky/engine/platform/exported/WebURLRequest.cpp View 1 chunk +0 lines, -335 lines 0 comments Download
D sky/engine/platform/exported/WebURLRequestPrivate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/platform/exported/WebURLResponse.cpp View 1 chunk +0 lines, -431 lines 0 comments Download
D sky/engine/platform/exported/WebURLResponsePrivate.h View 1 chunk +0 lines, -52 lines 0 comments Download
D sky/engine/platform/exported/WrappedResourceRequest.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/engine/platform/exported/WrappedResourceResponse.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/engine/platform/network/FormData.h View 1 chunk +0 lines, -134 lines 0 comments Download
D sky/engine/platform/network/FormData.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
D sky/engine/platform/network/FormDataBuilder.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/platform/network/FormDataBuilder.cpp View 1 chunk +0 lines, -225 lines 0 comments Download
D sky/engine/platform/network/HTTPHeaderMap.h View 1 chunk +0 lines, -81 lines 0 comments Download
D sky/engine/platform/network/HTTPHeaderMap.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/engine/platform/network/HTTPParsers.h View 1 chunk +0 lines, -103 lines 0 comments Download
D sky/engine/platform/network/HTTPParsers.cpp View 1 chunk +0 lines, -763 lines 0 comments Download
D sky/engine/platform/network/HTTPParsersTest.cpp View 1 chunk +0 lines, -226 lines 0 comments Download
D sky/engine/platform/network/HTTPRequest.h View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/engine/platform/network/HTTPRequest.cpp View 1 chunk +0 lines, -116 lines 0 comments Download
D sky/engine/platform/network/ParsedContentType.h View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/engine/platform/network/ParsedContentType.cpp View 1 chunk +0 lines, -226 lines 0 comments Download
D sky/engine/platform/network/ProxyServer.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/engine/platform/network/ProxyServer.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/platform/network/ResourceError.h View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/engine/platform/network/ResourceError.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D sky/engine/platform/network/ResourceLoadInfo.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/platform/network/ResourceLoadPriority.h View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/engine/platform/network/ResourceLoadTiming.h View 1 chunk +0 lines, -121 lines 0 comments Download
D sky/engine/platform/network/ResourceRequest.h View 1 chunk +0 lines, -213 lines 0 comments Download
D sky/engine/platform/network/ResourceRequest.cpp View 1 chunk +0 lines, -312 lines 0 comments Download
D sky/engine/platform/network/ResourceResponse.h View 1 chunk +0 lines, -255 lines 0 comments Download
D sky/engine/platform/network/ResourceResponse.cpp View 1 chunk +0 lines, -448 lines 0 comments Download
M sky/engine/public/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 3 chunks +0 lines, -7 lines 0 comments Download
D sky/engine/public/platform/WebHTTPBody.h View 1 chunk +0 lines, -104 lines 0 comments Download
D sky/engine/public/platform/WebHTTPHeaderVisitor.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/public/platform/WebHTTPLoadInfo.h View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/engine/public/platform/WebURLError.h View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/public/platform/WebURLLoadTiming.h View 1 chunk +0 lines, -108 lines 0 comments Download
D sky/engine/public/platform/WebURLLoader.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/public/platform/WebURLLoaderClient.h View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/engine/public/platform/WebURLRequest.h View 1 chunk +0 lines, -225 lines 0 comments Download
D sky/engine/public/platform/WebURLResponse.h View 1 chunk +0 lines, -200 lines 0 comments Download
M sky/services/platform/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D sky/services/platform/net_constants.h View 1 chunk +0 lines, -16 lines 0 comments Download
M sky/services/platform/platform_impl.h View 2 chunks +1 line, -6 lines 0 comments Download
M sky/services/platform/platform_impl.cc View 2 chunks +1 line, -24 lines 0 comments Download
D sky/services/platform/url_request_types.h View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/services/platform/url_request_types.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D sky/services/platform/weburlloader_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D sky/services/platform/weburlloader_impl.cc View 1 chunk +0 lines, -185 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 06:04:54 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-14 06:39:52 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cc602f4efa7bf5981d71c93eaf6720cb32417d9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698