Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issue 1239603002: Revert of Change fallback font collection in HarfBuzzShaper (Closed)

Created:
5 years, 5 months ago by eae
Modified:
5 years, 5 months ago
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Change fallback font collection in HarfBuzzShaper (patchset #3 id:40001 of https://codereview.chromium.org/1239513004/) Reason for revert: Caused a number of tests to crash on Mac 10.6 release that previously only crashed on 10.6 debug. media/track/track-cue-rendering-rtl.html inspector/elements/bidi-dom-tree.html virtual/antialiasedtext/fast/text/trailing_whitespace_wrapping.html imported/csswg-test/css-writing-modes-3/text-orientation-script-001k.html fast/css/word-spacing-characters-complex-text.html imported/csswg-test/css-writing-modes-3/text-orientation-script-001m.html virtual/antialiasedtext/fast/text/zero-width-characters-complex-script.html fast/text/zero-width-characters-complex-script.html fast/text/trailing_whitespace_wrapping.html Original issue's description: > Change fallback font collection in HarfBuzzShaper > > Change HarfBuzzShaper to not populate the fallback font list during text > shaping and instead populate it based on the ShapeResult objects at call > time. This circumvents additional registration work and renders the text > shaping API simpler and more consistent. > > R=leviw@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198813 TBR=leviw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M Source/platform/fonts/Font.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/fonts/shaping/CachingWordShapeIterator.h View 6 chunks +28 lines, -9 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShaper.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.h View 3 chunks +7 lines, -3 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 5 chunks +9 lines, -12 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 8 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eae
Created Revert of Change fallback font collection in HarfBuzzShaper
5 years, 5 months ago (2015-07-14 00:45:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239603002/1
5 years, 5 months ago (2015-07-14 00:45:44 UTC) #2
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-14 00:45:50 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 00:46:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198818

Powered by Google App Engine
This is Rietveld 408576698