Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: chrome/browser/extensions/updater/manifest_fetch_data.cc

Issue 12396002: Add chrome version information to extension update checks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/manifest_fetch_data.cc
diff --git a/chrome/browser/extensions/updater/manifest_fetch_data.cc b/chrome/browser/extensions/updater/manifest_fetch_data.cc
index 99e718f90b3e08c953a415ef34c66a9c1a933568..7dcb41cbd3e564f8de84f4b9703a42bfd52bdc10 100644
--- a/chrome/browser/extensions/updater/manifest_fetch_data.cc
+++ b/chrome/browser/extensions/updater/manifest_fetch_data.cc
@@ -12,6 +12,7 @@
#include "base/strings/string_number_conversions.h"
#include "chrome/browser/google/google_util.h"
#include "chrome/browser/metrics/metrics_service.h"
+#include "chrome/common/omaha_query_params.h"
#include "net/base/escape.h"
namespace {
@@ -27,6 +28,15 @@ namespace extensions {
ManifestFetchData::ManifestFetchData(const GURL& update_url, int request_id)
: base_url_(update_url),
full_url_(update_url) {
+chrome::OmahaQueryParams::ProdId prod =
+#if defined(GOOGLE_CHROME_BUILD)
+ chrome::OmahaQueryParams::CHROMECRX;
+#else
+ chrome::OmahaQueryParams::CHROMIUMCRX;
+#endif
+ full_url_ = GURL(full_url_.possibly_invalid_spec() +
sky 2013/03/07 01:25:33 Shouldn't you be using the gurl methods for buildi
jackhou1 2013/03/07 04:19:24 I couldn't find an easy way to add a list of param
+ (full_url_.has_query() ? "&" : "?") +
+ chrome::OmahaQueryParams::Get(prod));
request_ids_.insert(request_id);
}

Powered by Google App Engine
This is Rietveld 408576698