Add chrome version information to extension update checks

chrome/browser/extensions/updater/manifest_fetch_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/manifest_fetch_data.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/metrics/metrics_service.h"
+#include "chrome/common/omaha_query_params.h"
 #include "net/base/escape.h"
 
 namespace {
 
 // Maximum length of an extension manifest update check url, since it is a GET
 // request. We want to stay under 2K because of proxies, etc.
 const int kExtensionsManifestMaxURLSize = 2000;
 
 }  // namespace
 
 namespace extensions {
 
 ManifestFetchData::ManifestFetchData(const GURL& update_url, int request_id)
     : base_url_(update_url),
       full_url_(update_url) {
+chrome::OmahaQueryParams::ProdId prod =
+#if defined(GOOGLE_CHROME_BUILD)
+  chrome::OmahaQueryParams::CHROMECRX;
+#else
+  chrome::OmahaQueryParams::CHROMIUMCRX;
+#endif
+  full_url_ = GURL(full_url_.possibly_invalid_spec() +

[sky, 2013/03/07 01:25:33]

Shouldn't you be using the gurl methods for building a new url?

[jackhou1, 2013/03/07 04:19:24]

I couldn't find an easy way to add a list of params. I've changed it to use
ReplaceComponent, but it still requires checking if there's already a query. Let
me know if this is better or if I should change it back.

+                   (full_url_.has_query() ? "&" : "?") +
+                   chrome::OmahaQueryParams::Get(prod));
   request_ids_.insert(request_id);
 }
 
 ManifestFetchData::~ManifestFetchData() {}
 
 // The format for request parameters in update checks is:
 //
 //   ?x=EXT1_INFO&x=EXT2_INFO
 //
 // where EXT1_INFO and EXT2_INFO are url-encoded strings of the form:
@@ skipping 106 matching lines @@
     NOTREACHED();
   return value == kNeverPinged || value > 0;
 }
 
 void ManifestFetchData::Merge(const ManifestFetchData& other) {
   DCHECK(full_url() == other.full_url());
   request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
 }
 
 }  // namespace extensions