Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1239513004: Change fallback font collection in HarfBuzzShaper (Closed)

Created:
5 years, 5 months ago by eae
Modified:
5 years, 5 months ago
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change fallback font collection in HarfBuzzShaper Change HarfBuzzShaper to not populate the fallback font list during text shaping and instead populate it based on the ShapeResult objects at call time. This circumvents additional registration work and renders the text shaping API simpler and more consistent. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198813

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Kill _ALL_ the new lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -58 lines) Patch
M Source/platform/fonts/Font.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShapeIterator.h View 6 chunks +9 lines, -28 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShaper.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 2 3 chunks +3 lines, -7 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 5 chunks +12 lines, -9 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 8 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eae
5 years, 5 months ago (2015-07-13 20:40:09 UTC) #2
leviw_travelin_and_unemployed
LGTM I'm Sheryl I. Guerriero, Gerontologist and I approve this patch. http://imgur.com/wQs04wY https://codereview.chromium.org/1239513004/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaper.h File Source/platform/fonts/shaping/HarfBuzzShaper.h ...
5 years, 5 months ago (2015-07-13 20:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239513004/40001
5 years, 5 months ago (2015-07-13 20:51:12 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198813
5 years, 5 months ago (2015-07-13 23:06:05 UTC) #7
eae
5 years, 5 months ago (2015-07-14 00:45:17 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1239603002/ by eae@chromium.org.

The reason for reverting is: Caused a number of tests to crash on Mac 10.6
release that previously only crashed on 10.6 debug. 

media/track/track-cue-rendering-rtl.html
inspector/elements/bidi-dom-tree.html
virtual/antialiasedtext/fast/text/trailing_whitespace_wrapping.html
imported/csswg-test/css-writing-modes-3/text-orientation-script-001k.html
fast/css/word-spacing-characters-complex-text.html
imported/csswg-test/css-writing-modes-3/text-orientation-script-001m.html
virtual/antialiasedtext/fast/text/zero-width-characters-complex-script.html
fast/text/zero-width-characters-complex-script.html
fast/text/trailing_whitespace_wrapping.html.

Powered by Google App Engine
This is Rietveld 408576698