[NaCl SDK] Handle sources outside root in example build system

[NaCl SDK] Handle sources outside root in example build system.

For example SOURCES = ../../some/other/place.cpp.   The only
problem here was creating an OBJ_DIR relative path in which
to store the object file.  This solution involves replacing
.. with __.

Also, some make syntax cleanups for consistency:

- Use ifndef to check for empty variables
- Don't quote operands to 'ifeq'
- Always place ':' next to target name.
- remove include of .d files for win32 builds (which 
  do not generate them).

BUG=None
TEST=trybot


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186829

[binji, 2013-03-05 01:04:58]

probably should fix this for the other .mk files too.

https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/nacl_gcc.mk (right):

https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
native_client_sdk/src/tools/nacl_gcc.mk:47: # $2 = Arch sufffix
sp: suffix

https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
native_client_sdk/src/tools/nacl_gcc.mk:62: $(call SRC_TO_OBJ,$(1),x86_32): $(1)
$(TOP_MAKE) | $(call SRC_TO_OBJ,$(1),x86_32)dir.stamp
looks like you lost the call to $(dir)

[Sam Clegg, 2013-03-05 20:05:40]

Applied same fix for all toolchains.

https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/nacl_gcc.mk (right):

https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
native_client_sdk/src/tools/nacl_gcc.mk:47: # $2 = Arch sufffix
On 2013/03/05 01:04:58, binji wrote:
> sp: suffix

Done.

https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
native_client_sdk/src/tools/nacl_gcc.mk:62: $(call SRC_TO_OBJ,$(1),x86_32): $(1)
$(TOP_MAKE) | $(call SRC_TO_OBJ,$(1),x86_32)dir.stamp
On 2013/03/05 01:04:58, binji wrote:
> looks like you lost the call to $(dir)

Done.

[Sam Clegg, 2013-03-06 18:38:52]

PTAL

On 2013/03/05 20:05:40, Sam Clegg wrote:
> Applied same fix for all toolchains.
> 
>
https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
> File native_client_sdk/src/tools/nacl_gcc.mk (right):
> 
>
https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
> native_client_sdk/src/tools/nacl_gcc.mk:47: # $2 = Arch sufffix
> On 2013/03/05 01:04:58, binji wrote:
> > sp: suffix
> 
> Done.
> 
>
https://codereview.chromium.org/12395032/diff/2001/native_client_sdk/src/tool...
> native_client_sdk/src/tools/nacl_gcc.mk:62: $(call SRC_TO_OBJ,$(1),x86_32):
$(1)
> $(TOP_MAKE) | $(call SRC_TO_OBJ,$(1),x86_32)dir.stamp
> On 2013/03/05 01:04:58, binji wrote:
> > looks like you lost the call to $(dir)
> 
> Done.

[noelallen1, 2013-03-07 20:06:25]

https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
File native_client_sdk/src/tools/nacl_gcc.mk (right):

https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_gcc.mk:241: endef
Keep a blank line.  I've seen issues with patch on windows when patching near
end of files without extra line.

https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
File native_client_sdk/src/tools/nacl_llvm.mk (left):

https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:135: 
blank line.

[noelallen1, 2013-03-07 20:12:35]

On 2013/03/07 20:06:25, noelallen1 wrote:
>
https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
> File native_client_sdk/src/tools/nacl_gcc.mk (right):
> 
>
https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
> native_client_sdk/src/tools/nacl_gcc.mk:241: endef
> Keep a blank line.  I've seen issues with patch on windows when patching near
> end of files without extra line.
> 
>
https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
> File native_client_sdk/src/tools/nacl_llvm.mk (left):
> 
>
https://codereview.chromium.org/12395032/diff/20001/native_client_sdk/src/too...
> native_client_sdk/src/tools/nacl_llvm.mk:135: 
> blank line.

WRT blank line...  On windows, just because you are using Unix line endings it
does not mean the editor will place an LF at the end of the file.   Your
suggestion to just have a presubmit check makes sense to me.

[noelallen1, 2013-03-07 20:12:44]

lgtm

[commit-bot: I haz the power, 2013-03-07 21:32:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/12395032/20001

[commit-bot: I haz the power, 2013-03-08 00:41:32]

Change committed as 186829