[NaCl SDK] Handle sources outside root in example build system

native_client_sdk/src/tools/common.mk

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # GNU Make based build file.  For details on GNU Make see:
 #   http://www.gnu.org/software/make/manual/make.html
 #
 #
 
@@ skipping 11 matching lines @@
 #
 # Top Make file, which we want to trigger a rebuild on if it changes
 #
 TOP_MAKE:=$(word 1,$(MAKEFILE_LIST))
 
 
 #
 # Verify we selected a valid toolchain for this example
 #
 ifeq (,$(findstring $(TOOLCHAIN),$(VALID_TOOLCHAINS)))
-$(warning Availbile choices are: $(VALID_TOOLCHAINS))
-$(error Can not use TOOLCHAIN=$(TOOLCHAIN) on this example.)
+  $(warning Availbile choices are: $(VALID_TOOLCHAINS))
+  $(error Can not use TOOLCHAIN=$(TOOLCHAIN) on this example.)
 endif
 
 
 #
 # Build Configuration
 #
 # The SDK provides two sets of libraries, Debug and Release.  Debug libraries
 # are compiled without optimizations to make debugging easier.  By default
 # this will build a Debug configuration.
 #
 CONFIG?=Debug
 
 
-
 # Note for Windows:
-#   Both GCC and LLVM bases tools (include the version of Make.exe that comes
-# with the SDK) both expect and are capable of dealing with the '/' seperator.
-# For that reason, the tools in the SDK, including build, compilers, scripts
-# all have a preference for POSIX style command-line arguments.
+#   The GCC and LLVM toolchains (include the version of Make.exe that comes
+# with the SDK) expect and are capable of dealing with the '/' seperator.
+# For this reason, the tools in the SDK, including Makefiles and build scripts
+# have a preference for POSIX style command-line arguments.
 #
 # Keep in mind however that the shell is responsible for command-line escaping,
 # globbing, and variable expansion, so those may change based on which shell
 # is used.  For Cygwin shells this can include automatic and incorrect expansion
 # of response files (files starting with '@').
 #
 # Disable DOS PATH warning when using Cygwin based NaCl tools on Windows.
 #
-CYGWIN?=nodosfilewarning
-export CYGWIN
+ifeq ($(OSNAME),win)
+  CYGWIN?=nodosfilewarning
+  export CYGWIN
+endif
 
 
 #
 # If NACL_SDK_ROOT is not already set, then set it relative to this makefile.
 #
 THIS_MAKEFILE:=$(CURDIR)/$(lastword $(MAKEFILE_LIST))
-ifndef NACL_SDK_ROOT
-  NACL_SDK_ROOT:=$(realpath $(dir $(THIS_MAKEFILE))/..)
-endif
+NACL_SDK_ROOT?=$(realpath $(dir $(THIS_MAKEFILE))/..)
 
 
 #
 # Check that NACL_SDK_ROOT is set to a valid location.
 # We use the existence of tools/oshelpers.py to verify the validity of the SDK
 # root.
 #
 ifeq (,$(wildcard $(NACL_SDK_ROOT)/tools/oshelpers.py))
   $(error NACL_SDK_ROOT is set to an invalid location: $(NACL_SDK_ROOT))
 endif
@@ skipping 71 matching lines @@
         +$(MAKE) TOOLCHAIN=$(1)
 TOOLCHAIN_LIST+=all_$(1)
 endef
 
 
 #
 # The target for all versions
 #
 USABLE_TOOLCHAINS=$(filter $(OSNAME) newlib glibc pnacl,$(VALID_TOOLCHAINS))
 
-ifeq (1,$(NO_HOST_BUILDS))
+ifeq ($(NO_HOST_BUILDS),1)
 USABLE_TOOLCHAINS:=$(filter-out $(OSNAME),$(USABLE_TOOLCHAINS))
 endif
 
 $(foreach tool,$(USABLE_TOOLCHAINS),$(eval $(call TOOLCHAIN_RULE,$(tool),$(dep))))
 
 .PHONY: all_versions
 all_versions: $(TOOLCHAIN_LIST)
 
 
 OUTBASE?=.
@@ skipping 24 matching lines @@
 
 
 #
 # Dependency Macro
 #
 # $1 = Name of stamp
 # $2 = Directory for the sub-make
 # $3 = Extra Settings
 #
 define DEPEND_RULE
-ifeq (,$(IGNORE_DEPS))
+ifndef $(IGNORE_DEPS)
 .PHONY : rebuild_$(1)
 
 rebuild_$(1) :| $(STAMPDIR)/dir.stamp
 ifeq (,$(2))
         +$(MAKE) -C $(NACL_SDK_ROOT)/src/$(1) STAMPDIR=$(abspath $(STAMPDIR)) $(abspath $(STAMPDIR)/$(1).stamp) $(3)
 else
         +$(MAKE) -C $(2) STAMPDIR=$(abspath $(STAMPDIR)) $(abspath $(STAMPDIR)/$(1).stamp) $(3)
 endif
 
 all: rebuild_$(1)
 $(STAMPDIR)/$(1).stamp : rebuild_$(1)
 
 else
 
 .PHONY : $(STAMPDIR)/$(1).stamp
 $(STAMPDIR)/$(1).stamp :
         @echo Ignore $(1)
 endif
 endef
 
 
-
-ifeq ('win','$(TOOLCHAIN)')
+ifeq ($(TOOLCHAIN),win)
 HOST_EXT=.dll
 else
 HOST_EXT=.so
 endif
 
 
 #
 # Common Compile Options
 #
-ifeq ('Release','$(CONFIG)')
+ifeq ($(CONFIG),Release)
 POSIX_FLAGS?=-g -O2 -pthread -MMD
 else
 POSIX_FLAGS?=-g -O0 -pthread -MMD
 endif
 
 NACL_CFLAGS?=-Wno-long-long -Werror
 NACL_CXXFLAGS?=-Wno-long-long -Werror
 NACL_LDFLAGS?=-Wl,-as-needed
 
 #
@@ skipping 29 matching lines @@
 endef
 else
 define LOG
 @echo "  $(1) $(2)" && $(3)
 endef
 endif
 endif
 
 
 #
+# Convert a source path to a object file path.
+#
+# $1 = Source Name
+# $2 = Arch suffix
+#
+define SRC_TO_OBJ
+$(OUTDIR)/$(basename $(subst ..,__,$(1)))$(2).o
+endef
+
+
+#
+# Convert a source path to a dependency file path.
+#
+# $1 = Source Name
+# $2 = Arch suffix
+#
+define SRC_TO_DEP
+$(patsubst %.o,%.d,$(call SRC_TO_OBJ,$(1),$(2)))
+endef
+
+
+#
 # If the requested toolchain is a NaCl or PNaCl toolchain, the use the
 # macros and targets defined in nacl.mk, otherwise use the host sepecific
 # macros and targets.
 #
 ifneq (,$(findstring $(TOOLCHAIN),linux mac))
 include $(NACL_SDK_ROOT)/tools/host_gcc.mk
 endif
 
 ifneq (,$(findstring $(TOOLCHAIN),win))
 include $(NACL_SDK_ROOT)/tools/host_vc.mk
@@ skipping 12 matching lines @@
 #
 ifeq ($(OSNAME),win)
 DEV_NULL=nul
 else
 DEV_NULL=/dev/null
 endif
 
 #
 # Assign a sensible default to CHROME_PATH.
 #
-ifndef CHROME_PATH
-CHROME_PATH:=$(shell python $(NACL_SDK_ROOT)/tools/getos.py --chrome 2> $(DEV_NULL))
-endif
+CHROME_PATH?=$(shell python $(NACL_SDK_ROOT)/tools/getos.py --chrome 2> $(DEV_NULL))
 
 #
 # Verify we can find the Chrome executable if we need to launch it.
 #
 CHECK_FOR_CHROME:
 ifeq (,$(wildcard $(CHROME_PATH)))
         $(warning No valid Chrome found at CHROME_PATH=$(CHROME_PATH))
         $(error Set CHROME_PATH via an environment variable, or command-line.)
 else
         $(warning Using chrome at: $(CHROME_PATH))
@@ skipping 38 matching lines @@
 GDB_ARGS+=-D $(abspath $(OUTDIR))/$(TARGET)_$(SYSARCH).nexe
 
 DEBUG: CHECK_FOR_CHROME all
         $(RUN_PY) $(GDB_ARGS) \
             -C $(CURDIR) -P $(PAGE_TC_CONFIG) \
             $(addprefix -E ,$(CHROME_ENV)) -- $(CHROME_PATH) $(CHROME_ARGS) \
             --enable-nacl-debug \
             --register-pepper-plugins="$(PPAPI_DEBUG),$(PPAPI_RELEASE)"
 
 .PHONY: CHECK_FOR_CHROME RUN LAUNCH