Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1239263003: Restore depot_tools autoupdate in Windows. (Closed)

Created:
5 years, 5 months ago by Sergiy Byelozyorov
Modified:
5 years, 4 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore depot_tools autoupdate in Windows. Original CL: https://codereview.chromium.org/1242013003/ The credit for this fix goes to bratell@opera.com. Executing a bat file from another bat file will replace that first bat file with the second one. To call the second one and then return and execute the rest of the first one, you have to do "call second.bat" "python" is really "python.bat" so that this happened was not obvious. More obvious now. R=bratell@opera.com TBR=pgervais@chromium.org BUG=511926 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=296063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M update_depot_tools.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergiy Byelozyorov
5 years, 5 months ago (2015-07-20 11:19:54 UTC) #1
Daniel Bratell
lgtm (since it's the same as looked good to you), but I do not think ...
5 years, 5 months ago (2015-07-20 11:37:18 UTC) #2
Sergiy Byelozyorov
Committed patchset #1 (id:1) manually as 296063 (presubmit successful).
5 years, 5 months ago (2015-07-20 11:55:40 UTC) #3
Sergiy Byelozyorov
On 2015/07/20 11:37:18, Daniel Bratell wrote: > lgtm (since it's the same as looked good ...
5 years, 5 months ago (2015-07-20 11:56:13 UTC) #4
pgervais
5 years, 5 months ago (2015-07-21 01:38:44 UTC) #5
Message was sent while issue was closed.
On 2015/07/20 11:56:13, Sergiy Byelozyorov wrote:
> On 2015/07/20 11:37:18, Daniel Bratell wrote:
> > lgtm (since it's the same as looked good to you), but I do not think my LGTM
> is
> > enough since I lack the committer bit. Maybe I should figure out how to get
> it,
> > but normally CQ takes care of things and it doesn't matter.
> 
> I am a committer, so I can land this manually (git cl land), but to avoid
> skipping presubmit checks I need someone else's LGTM. If you want to become a
> committer yourself, please follow the process descirbed at
> https://www.chromium.org/getting-involved/become-a-committer. Thanks again for
> fixing this.

lgtm

Powered by Google App Engine
This is Rietveld 408576698