Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 12389082: make gyp recognize OpenBSD (Closed)

Created:
7 years, 9 months ago by qbit
Modified:
7 years, 9 months ago
Reviewers:
Nico, qbit
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make gyp recognize OpenBSD BUG=311 Landed in skia r1590.

Patch Set 1 #

Total comments: 1

Patch Set 2 : make gyp recognize OpenBSD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pylib/gyp/common.py View 1 chunk +2 lines, -0 lines 0 comments Download
M pylib/gyp/common_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M pylib/gyp/generator/make.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
https://codereview.chromium.org/12389082/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/12389082/diff/1/pylib/gyp/generator/make.py#newcode1987 pylib/gyp/generator/make.py:1987: elif flavor == 'freebsd': Can you just write `elif ...
7 years, 9 months ago (2013-03-04 18:48:08 UTC) #1
qbit
On 2013/03/04 18:48:08, Nico wrote: > https://codereview.chromium.org/12389082/diff/1/pylib/gyp/generator/make.py > File pylib/gyp/generator/make.py (right): > > https://codereview.chromium.org/12389082/diff/1/pylib/gyp/generator/make.py#newcode1987 > ...
7 years, 9 months ago (2013-03-04 18:51:06 UTC) #2
Nico
Thanks! Do you need a change like the one in make.py in ninja.py too? Or ...
7 years, 9 months ago (2013-03-04 18:59:25 UTC) #3
qbit
On 2013/03/04 18:59:25, Nico wrote: > Thanks! > > Do you need a change like ...
7 years, 9 months ago (2013-03-04 19:06:29 UTC) #4
qbit
not currently using ninja.
7 years, 9 months ago (2013-03-04 19:10:45 UTC) #5
Nico
Ok, lgtm, I'll land this. Give ninja a try though, it's much much nicer than ...
7 years, 9 months ago (2013-03-04 19:11:52 UTC) #6
Nico
Landed in skia r1590.
7 years, 9 months ago (2013-03-04 19:39:50 UTC) #7
Nico
+qbit, who did the change you're partially undoing. qbit, does this look right?
7 years, 9 months ago (2013-03-14 21:13:24 UTC) #8
Nico
7 years, 9 months ago (2013-03-14 21:13:37 UTC) #9
Message was sent while issue was closed.
On 2013/03/14 21:13:24, Nico wrote:
> +qbit, who did the change you're partially undoing. qbit, does this look
right?

Err, wrong review. Let me try that again.

Powered by Google App Engine
This is Rietveld 408576698