Issue 1238843002: Cherry-pick upstream r238083

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1238843002: Cherry-pick upstream r238083 (Closed)

Created:
5 years, 5 months ago by Derek Schuff

Modified:
5 years, 5 months ago

Reviewers:
JF

CC:
native-client-reviews_googlegroups.com, jungshik at Google

Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cherry-pick upstream r238083 [Sema] Don't use dyn_cast to detect an AtomicType An AtomicType might be hidden behind arbitrary levels of typedefs. getAs<> will reliably walk through the sugar to get the underlying AtomicType. This fixes PR23638. R=jfb@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=4228 Committed: c82d6a256cb2ce61e7099cff731da327a72e23f7

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	lib/Sema/SemaChecking.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/Sema/atomic-compare.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Derek Schuff

5 years, 5 months ago (2015-07-15 16:02:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c82d6a256cb2ce61e7099cff731da327a72e23f7 (tree was closed).

Expand Messages | Collapse Messages