lib/Sema/SemaChecking.cpp - Issue 1238843002: Cherry-pick upstream r238083

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Sema/SemaChecking.cpp

Issue 1238843002: Cherry-pick upstream r238083 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-clang.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/Sema/SemaChecking.cpp

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp

index 05eaaec5792ae1c1c3bd0be9dda81b95381ad9e6..d8998cfff4fe0750150c9f61dd070d1c1aa7e8ef 100644

--- a/lib/Sema/SemaChecking.cpp

+++ b/lib/Sema/SemaChecking.cpp

@@ -6052,7 +6052,7 @@ static void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E,

// TODO: Investigate using GetExprRange() to get tighter bounds

// on the bit ranges.

QualType OtherT = Other->getType();

- if (const AtomicType *AT = dyn_cast<AtomicType>(OtherT))

+ if (const auto *AT = OtherT->getAs<AtomicType>())

OtherT = AT->getValueType();

IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT);

unsigned OtherWidth = OtherRange.Width;

« no previous file with comments | « no previous file | test/Sema/atomic-compare.c » ('j') | no next file with comments »