[turbofan] Implement super call support in TurboFan.

[turbofan] Implement super call support in TurboFan.

R=rossberg@chromium.org

Committed: https://crrev.com/b76acef799bd07346918a78c5eb1d8ebf085975b
Cr-Commit-Position: refs/heads/master@{#29696}

[Michael Starzinger, 2015-07-14 16:21:24]

Note that this is not yet intended to be landed, it should just serve as food
for thought on how to cleanup the initialization of "this" in derived
constructors. Let me know if you have ideas on how to get this cleaned up.

[Michael Starzinger, 2015-07-15 13:13:41]

Patchset #2 (id:20001) has been deleted

[Michael Starzinger, 2015-07-15 13:49:31]

Found a way to make this fit into the current abstractions. This should also
allow us to represent the binding of {this} within the AST (if we adapt
full-codegen in a similar fashion). Promoting this CL from "work-in-progress" to
"solution". PTAL.

[Michael Starzinger, 2015-07-15 14:23:10]

Added some tests and *drumroll* found a bug already of course.

[rossberg, 2015-07-15 15:00:42]

lgtm

https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph...
src/compiler/ast-graph-builder.cc:3288: Node*
AstGraphBuilder::BuildHoleCheckElseThrow(Node* value, Variable* variable,
Nit: Can't you share the impls of these functions? They only need to differ in
their choice of equality operator (=== vs !===).

[Michael Starzinger, 2015-07-16 07:55:18]

https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph...
src/compiler/ast-graph-builder.cc:3288: Node*
AstGraphBuilder::BuildHoleCheckElseThrow(Node* value, Variable* variable,
On 2015/07/15 15:00:41, rossberg wrote:
> Nit: Can't you share the impls of these functions? They only need to differ in
> their choice of equality operator (=== vs !===).

Done. I hope this is what you had in mind, I wasn't entirely sure.

[Michael Starzinger, 2015-07-16 08:10:20]

https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph...
src/compiler/ast-graph-builder.cc:3288: Node*
AstGraphBuilder::BuildHoleCheckElseThrow(Node* value, Variable* variable,
On 2015/07/16 07:55:18, Michael Starzinger wrote:
> On 2015/07/15 15:00:41, rossberg wrote:
> > Nit: Can't you share the impls of these functions? They only need to differ
in
> > their choice of equality operator (=== vs !===).
> 
> Done. I hope this is what you had in mind, I wasn't entirely sure.

Unfortunately I needed to undo this, because Token::NE_STRICT is not supported
by our CompareICs. We always deconstruct (a !=== b) into !(a === b) in
ParserBase::ParseBinaryExpression in the parser.

[Michael Starzinger, 2015-07-16 08:18:49]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-07-16 08:18:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1238743002/#ps140001
(title: "Revert "Addressed comments."")

[commit-bot: I haz the power, 2015-07-16 08:19:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238743002/140001

[commit-bot: I haz the power, 2015-07-16 08:54:01]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2015-07-16 08:54:13]

Patchset 7 (id:??) landed as
https://crrev.com/b76acef799bd07346918a78c5eb1d8ebf085975b
Cr-Commit-Position: refs/heads/master@{#29696}