src/compiler/js-generic-lowering.cc - Issue 1238743002: [turbofan] Implement super call support in TurboFan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1238743002: [turbofan] Implement super call support in TurboFan. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-super-2

Patch Set: Revert "Addressed comments." Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index 84ee3933e22a28ba715417ed7222fdca7aa117bd..e3e4cddd8a3697723d31b376527f2b876153ca56 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -537,7 +537,7 @@ void JSGenericLowering::LowerJSCreateCatchContext(Node* node) {

void JSGenericLowering::LowerJSCallConstruct(Node* node) {

int arity = OpParameter<int>(node);

- CallConstructStub stub(isolate(), NO_CALL_CONSTRUCTOR_FLAGS);

+ CallConstructStub stub(isolate(), SUPER_CONSTRUCTOR_CALL);

CallInterfaceDescriptor d = stub.GetCallInterfaceDescriptor();

CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);

CallDescriptor* desc =

« no previous file with comments | « src/compiler/ast-loop-assignment-analyzer.cc ('k') | test/mjsunit/harmony/super.js » ('j') | no next file with comments »