Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: src/pdf/SkPDFFormXObject.cpp

Issue 12387086: Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors … (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/pdf/SkPDFFormXObject.cpp
===================================================================
--- src/pdf/SkPDFFormXObject.cpp (revision 7963)
+++ src/pdf/SkPDFFormXObject.cpp (working copy)
@@ -26,10 +26,6 @@
// If there is an issue, getResources will end up consuming all memory.
// TODO: A better approach might be for all SkPDFObject to keep track
// of possible cycles.
-#ifdef SK_DEBUG
- SkTDArray<SkPDFObject*> dummy_resourceList;
- getResources(&dummy_resourceList);
-#endif
SkAutoTUnref<SkStream> content(device->content());
setData(content.get());

Powered by Google App Engine
This is Rietveld 408576698