Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors …

src/pdf/SkPDFFormXObject.cpp

 
 /*
  * Copyright 2010 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkPDFFormXObject.h"
 
 #include "SkMatrix.h"
 #include "SkPDFCatalog.h"
 #include "SkPDFDevice.h"
 #include "SkPDFUtils.h"
 #include "SkStream.h"
 #include "SkTypes.h"
 
 SkPDFFormXObject::SkPDFFormXObject(SkPDFDevice* device) {
     // We don't want to keep around device because we'd have two copies
     // of content, so reference or copy everything we need (content and
     // resources).
     device->getResources(&fResources, false);
 
     // Fail fast if in the tree of resources a child references a parent.
     // If there is an issue, getResources will end up consuming all memory.
     // TODO: A better approach might be for all SkPDFObject to keep track
     // of possible cycles.
-#ifdef SK_DEBUG
-    SkTDArray<SkPDFObject*> dummy_resourceList;
-    getResources(&dummy_resourceList);
-#endif
 
     SkAutoTUnref<SkStream> content(device->content());
     setData(content.get());
 
     insertName("Type", "XObject");
     insertName("Subtype", "Form");
     SkSafeUnref(this->insert("BBox", device->copyMediaBox()));
     insert("Resources", device->getResourceDict());
 
     // We invert the initial transform and apply that to the xobject so that
@@ skipping 17 matching lines @@
     insert("Group", group.get());
 }
 
 SkPDFFormXObject::~SkPDFFormXObject() {
     fResources.unrefAll();
 }
 
 void SkPDFFormXObject::getResources(SkTDArray<SkPDFObject*>* resourceList) {
     GetResourcesHelper(&fResources, resourceList);
 }