Issue 12387075: Comment out NOTIMPLEMENTED in OmniboxViewGtk::ApplyCaretVisibility to avoid test errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12387075: Comment out NOTIMPLEMENTED in OmniboxViewGtk::ApplyCaretVisibility to avoid test errors (Closed)

Created:
7 years, 9 months ago by kinuko

Modified:
7 years, 9 months ago

Reviewers:
aelias_OOO_until_Jul13, Elliot Glaysher

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Comment out NOTIMPLEMENTED in OmniboxViewGtk::ApplyCaretVisibility to avoid test errors Some tests seem to have started failing after webkit r144581: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/26633 BUG=179760 TEST=GpuFeatureTest.AcceleratedCompositingAllowed,DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_InterruptedResume TBR=erg@chromium.org,aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185835

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

kinuko

Committed patchset #1 manually as r185835 (presubmit successful).

7 years, 9 months ago (2013-03-04 04:59:06 UTC) #2

kinuko

7 years, 9 months ago (2013-03-04 07:35:46 UTC) #3

Message was sent while issue was closed.

Reverting this one as it does nothing (my try job didn't include DEPS  change
:()