chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc - Issue 12387075: Comment out NOTIMPLEMENTED in OmniboxViewGtk::ApplyCaretVisibility to avoid test errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 12387075: Comment out NOTIMPLEMENTED in OmniboxViewGtk::ApplyCaretVisibility to avoid test errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

index 2874d382d1335b9975b96ffdd6264b636549e2b8..e335445163e329fd908865bde0354baf2cd6f37f 100644

--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

@@ -428,7 +428,8 @@ void OmniboxViewGtk::SetFocus() {

void OmniboxViewGtk::ApplyCaretVisibility() {

// TODO(mathp): implement for Linux.

- NOTIMPLEMENTED();

+ // This started to get hit after WebKit r144580.

+ // NOTIMPLEMENTED();

}

int OmniboxViewGtk::WidthOfTextAfterCursor() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »