Fix for CookieManager init race condition

android_webview/browser/net/aw_url_request_context_getter.cc

Index: android_webview/browser/net/aw_url_request_context_getter.cc
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index 6ec1aad7db56be9a00b7ec48b95294e4e9187db7..f728c559d22c3853e5b334880178e66e06180b49 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -72,6 +72,8 @@ void AwURLRequestContextGetter::Init() {
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
   main_http_factory_.reset(main_cache);
   url_request_context_->set_http_transaction_factory(main_cache);
+
+  DidCreateURLRequestContextOnIOThread(url_request_context_.get());

[boliu, 2013/03/01 00:19:06]

This is not true...the getter is initialized but the context has not been
created yet.

Can we make this non-laziness explicit? ie copy all of the initialization code
in GetURLRequestContext here, then add a comment saying why we can't be lazy.

[Kristian Monsen, 2013/03/01 00:19:08]

Can this safely be used before the job factory is created?

[joth, 2013/03/01 00:28:13]

 I think you mean the opposite? the request context is created (that happend up
on line 61) but not (fully) initialized yet: it does not have all the job
factories installed.

Note the method here is merely DidCreate.... not DidCreateAndInit
but that's very subtle :-)

Would it be clearer if I just passed the net::CookieMonster* here? That's all
that is needed, and we know that is fully created at this point
As AwURLRequestContextGetter::Init() blocks the UI thread, it'd be nice to
minimize what we do in here if it is possible...

 }
 
 void AwURLRequestContextGetter::PopulateNetworkSessionParams(
@@ -118,8 +120,7 @@ net::URLRequestContext* AwURLRequestContextGetter::GetURLRequestContext() {
     DCHECK(set_protocol);
     // Create a chain of URLRequestJobFactories.  Keep |job_factory_| pointed
     // at the beginning of the chain.
-    job_factory_ = CreateAndroidJobFactoryAndCookieMonster(
-        url_request_context_.get(), job_factory.Pass());
+    job_factory_ = CreateAndroidJobFactory(job_factory.Pass());
     job_factory_.reset(new net::ProtocolInterceptJobFactory(
         job_factory_.Pass(),
         scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>(