Fix for CookieManager init race condition

android_webview/browser/net/aw_url_request_context_getter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/net/aw_url_request_context_getter.h"
 
 #include "android_webview/browser/aw_browser_context.h"
 #include "android_webview/browser/aw_request_interceptor.h"
 #include "android_webview/browser/net/aw_network_delegate.h"
 #include "android_webview/browser/net/aw_url_request_job_factory.h"
@@ skipping 54 matching lines @@
   PopulateNetworkSessionParams(&network_session_params);
   net::HttpCache* main_cache = new net::HttpCache(
       network_session_params,
       new net::HttpCache::DefaultBackend(
           net::DISK_CACHE,
           browser_context_->GetPath().Append(FILE_PATH_LITERAL("Cache")),
           10 * 1024 * 1024,  // 10M
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
   main_http_factory_.reset(main_cache);
   url_request_context_->set_http_transaction_factory(main_cache);
+
+  DidCreateURLRequestContextOnIOThread(url_request_context_.get());

[boliu, 2013/03/01 00:19:06]

This is not true...the getter is initialized but the context has not been
created yet.

Can we make this non-laziness explicit? ie copy all of the initialization code
in GetURLRequestContext here, then add a comment saying why we can't be lazy.

[Kristian Monsen, 2013/03/01 00:19:08]

Can this safely be used before the job factory is created?

[joth, 2013/03/01 00:28:13]

 I think you mean the opposite? the request context is created (that happend up
on line 61) but not (fully) initialized yet: it does not have all the job
factories installed.

Note the method here is merely DidCreate.... not DidCreateAndInit
but that's very subtle :-)

Would it be clearer if I just passed the net::CookieMonster* here? That's all
that is needed, and we know that is fully created at this point
As AwURLRequestContextGetter::Init() blocks the UI thread, it'd be nice to
minimize what we do in here if it is possible...

 }
 
 void AwURLRequestContextGetter::PopulateNetworkSessionParams(
     net::HttpNetworkSession::Params* params) {
   net::URLRequestContext* context = url_request_context_.get();
   params->host_resolver = context->host_resolver();
   params->cert_verifier = context->cert_verifier();
   params->server_bound_cert_service = context->server_bound_cert_service();
   params->transport_security_state = context->transport_security_state();
   params->proxy_service = context->proxy_service();
@@ skipping 26 matching lines @@
     set_protocol = job_factory->SetProtocolHandler(
         chrome::kChromeUIScheme, chrome_protocol_handler_.release());
     DCHECK(set_protocol);
     DCHECK(chrome_devtools_protocol_handler_);
     set_protocol = job_factory->SetProtocolHandler(
         chrome::kChromeDevToolsScheme,
         chrome_devtools_protocol_handler_.release());
     DCHECK(set_protocol);
     // Create a chain of URLRequestJobFactories.  Keep |job_factory_| pointed
     // at the beginning of the chain.
-    job_factory_ = CreateAndroidJobFactoryAndCookieMonster(
-        url_request_context_.get(), job_factory.Pass());
+    job_factory_ = CreateAndroidJobFactory(job_factory.Pass());
     job_factory_.reset(new net::ProtocolInterceptJobFactory(
         job_factory_.Pass(),
         scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>(
             new AwRequestInterceptor())));
     job_factory_.reset(new net::ProtocolInterceptJobFactory(
         job_factory_.Pass(),
         developer_protocol_handler_.Pass()));
     url_request_context_->set_job_factory(job_factory_.get());
   }
   return url_request_context_.get();
@@ skipping 16 matching lines @@
     scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
         chrome_devtools_protocol_handler) {
   blob_protocol_handler_ = blob_protocol_handler.Pass();
   file_system_protocol_handler_ = file_system_protocol_handler.Pass();
   developer_protocol_handler_ = developer_protocol_handler.Pass();
   chrome_protocol_handler_ = chrome_protocol_handler.Pass();
   chrome_devtools_protocol_handler_ = chrome_devtools_protocol_handler.Pass();
 }
 
 }  // namespace android_webview