runtime/bin/socket_patch.dart - Issue 12387014: Correctly close done future with an error, before a normal complete can happen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 12387014: Correctly close done future with an error, before a normal complete can happen. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index 3f7362858ba49241c8432f76e3cbc830ec0b0c32..89f621967716be645f02eb843cc8d19ade37fd09 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -902,11 +902,11 @@ class _Socket extends Stream<List<int>> implements Socket {

}

void _consumerDone([error]) {

+ _done(error);

if (_raw != null) {

_raw.shutdown(SocketDirection.SEND);

_disableWriteEvent();

}

- _done(error);

}

« no previous file with comments | « no previous file | tests/standalone/io/stdout_bad_argument_test.dart » ('j') | no next file with comments »