Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: runtime/bin/socket_patch.dart

Issue 12387014: Correctly close done future with an error, before a normal complete can happen. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/standalone/io/stdout_bad_argument_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 patch class RawServerSocket { 5 patch class RawServerSocket {
6 /* patch */ static Future<RawServerSocket> bind([String address = "127.0.0.1", 6 /* patch */ static Future<RawServerSocket> bind([String address = "127.0.0.1",
7 int port = 0, 7 int port = 0,
8 int backlog = 0]) { 8 int backlog = 0]) {
9 return _RawServerSocket.bind(address, port, backlog); 9 return _RawServerSocket.bind(address, port, backlog);
10 } 10 }
(...skipping 884 matching lines...) Expand 10 before | Expand all | Expand 10 after
895 _raw.writeEventsEnabled = true; 895 _raw.writeEventsEnabled = true;
896 } 896 }
897 897
898 void _disableWriteEvent() { 898 void _disableWriteEvent() {
899 if (_raw != null) { 899 if (_raw != null) {
900 _raw.writeEventsEnabled = false; 900 _raw.writeEventsEnabled = false;
901 } 901 }
902 } 902 }
903 903
904 void _consumerDone([error]) { 904 void _consumerDone([error]) {
905 _done(error);
905 if (_raw != null) { 906 if (_raw != null) {
906 _raw.shutdown(SocketDirection.SEND); 907 _raw.shutdown(SocketDirection.SEND);
907 _disableWriteEvent(); 908 _disableWriteEvent();
908 } 909 }
909 _done(error);
910 } 910 }
911 } 911 }
912 912
913 913
914 class _SecureSocket extends _Socket implements SecureSocket { 914 class _SecureSocket extends _Socket implements SecureSocket {
915 _SecureSocket(RawSecureSocket raw) : super(raw); 915 _SecureSocket(RawSecureSocket raw) : super(raw);
916 916
917 void set onBadCertificate(bool callback(X509Certificate certificate)) { 917 void set onBadCertificate(bool callback(X509Certificate certificate)) {
918 if (_raw == null) { 918 if (_raw == null) {
919 throw new StateError("onBadCertificate called on destroyed SecureSocket"); 919 throw new StateError("onBadCertificate called on destroyed SecureSocket");
920 } 920 }
921 _raw.onBadCertificate = callback; 921 _raw.onBadCertificate = callback;
922 } 922 }
923 923
924 X509Certificate get peerCertificate { 924 X509Certificate get peerCertificate {
925 if (_raw == null) { 925 if (_raw == null) {
926 throw new StateError("peerCertificate called on destroyed SecureSocket"); 926 throw new StateError("peerCertificate called on destroyed SecureSocket");
927 } 927 }
928 return _raw.peerCertificate; 928 return _raw.peerCertificate;
929 } 929 }
930 } 930 }
OLDNEW
« no previous file with comments | « no previous file | tests/standalone/io/stdout_bad_argument_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698