Issue 1238613004: [Merge to M45] Fix order of arguments in QuicStreamFactory constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1238613004: [Merge to M45] Fix order of arguments in QuicStreamFactory constructor. (Closed)

Created:
5 years, 5 months ago by Ryan Hamilton

Modified:
5 years, 5 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

[Merge to M45] Fix order of arguments in QuicStreamFactory constructor. https://codereview.chromium.org/1208933004 added new arguments to the QuicStreamFactory constructor but the code in HttpNetworkSession which invokes this constructor had a typo in the argument order. BUG=500919, 510021 TBR=rtenneti@chromium.org Review URL: https://codereview.chromium.org/1235163003 Cr-Commit-Position: refs/heads/master@{#338776} (cherry picked from commit 185ebee1f24d5bc94d4670bece9291ae9abd48eb) Committed: https://chromium.googlesource.com/chromium/src/+/b1395f41d8620dd38b7e9f8063e5c4f5d59b2518

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	net/http/http_network_session.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_stream_factory.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Ryan Hamilton

Committed patchset #1 (id:1) manually as b1395f41d8620dd38b7e9f8063e5c4f5d59b2518 (presubmit successful).

5 years, 5 months ago (2015-07-16 20:19:03 UTC) #2

Message was sent while issue was closed.

lgtm