Issue 1235163003: Fix order of arguments in QuicStreamFactory constructor.

Issue 1235163003: Fix order of arguments in QuicStreamFactory constructor. (Closed)

Created:
5 years, 5 months ago by Ryan Hamilton

Modified:
5 years, 5 months ago

Reviewers:
Buck, mef

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix order of arguments in QuicStreamFactory constructor. https://codereview.chromium.org/1208933004 added new arguments to the QuicStreamFactory constructor but the code in HttpNetworkSession which invokes this constructor had a typo in the argument order. BUG=500919, 510021 Committed: https://crrev.com/185ebee1f24d5bc94d4670bece9291ae9abd48eb Cr-Commit-Position: refs/heads/master@{#338776}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
M	net/http/http_network_session.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_stream_factory.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 10 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235163003/20001

5 years, 5 months ago (2015-07-14 22:31:59 UTC) #8

commit-bot: I haz the power

5 years, 5 months ago (2015-07-14 23:57:27 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/185ebee1f24d5bc94d4670bece9291ae9abd48eb
Cr-Commit-Position: refs/heads/master@{#338776}