Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1238533003: Use the LookupIterator to transition to elements accessors (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use the LookupIterator to transition to elements accessors BUG=v8:4137 LOG=n Committed: https://crrev.com/170896e6bff8773895e10b68d8f28c10e46ac46f Cr-Commit-Position: refs/heads/master@{#29645}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Disallow defining accessors on typed arrays #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -127 lines) Patch
M src/lookup.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/lookup.cc View 3 chunks +38 lines, -11 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +15 lines, -110 lines 0 comments Download
A test/mjsunit/element-accessor.js View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal api accessors (AccessorInfo) still needs to be migrated entirely, so for now I'll have ...
5 years, 5 months ago (2015-07-14 09:45:25 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-14 10:20:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238533003/40001
5 years, 5 months ago (2015-07-14 10:22:41 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-14 10:53:11 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 10:53:30 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/170896e6bff8773895e10b68d8f28c10e46ac46f
Cr-Commit-Position: refs/heads/master@{#29645}

Powered by Google App Engine
This is Rietveld 408576698