src/lookup.h - Issue 1238533003: Use the LookupIterator to transition to elements accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.h

Issue 1238533003: Use the LookupIterator to transition to elements accessors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Disallow defining accessors on typed arrays Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.h

diff --git a/src/lookup.h b/src/lookup.h

index 20a4b73fb0d4f22e32e1c18edcd0153c8c367e13..6221d6741d2d7d687536662a25a960d974aeb9fa 100644

--- a/src/lookup.h

+++ b/src/lookup.h

@@ -168,7 +168,7 @@ class LookupIterator final BASE_EMBEDDED {

Handle<Name> GetName() {

if (name_.is_null()) {

DCHECK(IsElement());

- name_ = isolate_->factory()->Uint32ToString(index_);

+ name_ = factory()->Uint32ToString(index_);

}

return name_;

}

@@ -183,6 +183,7 @@ class LookupIterator final BASE_EMBEDDED {

state_ = NOT_FOUND;

}

+ Heap* heap() const { return isolate_->heap(); }

Factory* factory() const { return isolate_->factory(); }

Handle<Object> GetReceiver() const { return receiver_; }

Handle<JSObject> GetStoreTarget() const;

« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »