Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 12385082: Make sure builtin functions don't rely on __proto__. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Make sure builtin functions don't rely on __proto__. This makes sure that none of the builtin functions rely on the __proto__ accessor which can now be monkey-patched by applications. Instead use a separate %SetPrototype() intrinsic or object literals to do the job. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -21 lines) Patch
M src/apinatives.js View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/array.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/d8.js View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/math.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/proxy.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/v8natives.js View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-03-04 14:14:44 UTC) #1
rossberg
lgtm
7 years, 9 months ago (2013-03-04 15:07:04 UTC) #2
Michael Starzinger
7 years, 9 months ago (2013-03-04 16:05:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13815 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698