Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 12385082: Make sure builtin functions don't rely on __proto__. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/apinatives.js ('k') | src/array.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1628 matching lines...) Expand 10 before | Expand all | Expand 10 after
1639 Handle<Code> ic = is_classic_mode() 1639 Handle<Code> ic = is_classic_mode()
1640 ? isolate()->builtins()->StoreIC_Initialize() 1640 ? isolate()->builtins()->StoreIC_Initialize()
1641 : isolate()->builtins()->StoreIC_Initialize_Strict(); 1641 : isolate()->builtins()->StoreIC_Initialize_Strict();
1642 CallIC(ic, RelocInfo::CODE_TARGET, key->LiteralFeedbackId()); 1642 CallIC(ic, RelocInfo::CODE_TARGET, key->LiteralFeedbackId());
1643 PrepareForBailoutForId(key->id(), NO_REGISTERS); 1643 PrepareForBailoutForId(key->id(), NO_REGISTERS);
1644 } else { 1644 } else {
1645 VisitForEffect(value); 1645 VisitForEffect(value);
1646 } 1646 }
1647 break; 1647 break;
1648 } 1648 }
1649 // Fall through.
1650 case ObjectLiteral::Property::PROTOTYPE:
1651 // Duplicate receiver on stack. 1649 // Duplicate receiver on stack.
1652 __ ldr(r0, MemOperand(sp)); 1650 __ ldr(r0, MemOperand(sp));
1653 __ push(r0); 1651 __ push(r0);
1654 VisitForStackValue(key); 1652 VisitForStackValue(key);
1655 VisitForStackValue(value); 1653 VisitForStackValue(value);
1656 if (property->emit_store()) { 1654 if (property->emit_store()) {
1657 __ mov(r0, Operand(Smi::FromInt(NONE))); // PropertyAttributes 1655 __ mov(r0, Operand(Smi::FromInt(NONE))); // PropertyAttributes
1658 __ push(r0); 1656 __ push(r0);
1659 __ CallRuntime(Runtime::kSetProperty, 4); 1657 __ CallRuntime(Runtime::kSetProperty, 4);
1660 } else { 1658 } else {
1661 __ Drop(3); 1659 __ Drop(3);
1662 } 1660 }
1663 break; 1661 break;
1662 case ObjectLiteral::Property::PROTOTYPE:
1663 // Duplicate receiver on stack.
1664 __ ldr(r0, MemOperand(sp));
1665 __ push(r0);
1666 VisitForStackValue(value);
1667 if (property->emit_store()) {
1668 __ CallRuntime(Runtime::kSetPrototype, 2);
1669 } else {
1670 __ Drop(2);
1671 }
1672 break;
1673
1664 case ObjectLiteral::Property::GETTER: 1674 case ObjectLiteral::Property::GETTER:
1665 accessor_table.lookup(key)->second->getter = value; 1675 accessor_table.lookup(key)->second->getter = value;
1666 break; 1676 break;
1667 case ObjectLiteral::Property::SETTER: 1677 case ObjectLiteral::Property::SETTER:
1668 accessor_table.lookup(key)->second->setter = value; 1678 accessor_table.lookup(key)->second->setter = value;
1669 break; 1679 break;
1670 } 1680 }
1671 } 1681 }
1672 1682
1673 // Emit code to define accessors, using only a single call to the runtime for 1683 // Emit code to define accessors, using only a single call to the runtime for
(...skipping 2892 matching lines...) Expand 10 before | Expand all | Expand 10 after
4566 *context_length = 0; 4576 *context_length = 0;
4567 return previous_; 4577 return previous_;
4568 } 4578 }
4569 4579
4570 4580
4571 #undef __ 4581 #undef __
4572 4582
4573 } } // namespace v8::internal 4583 } } // namespace v8::internal
4574 4584
4575 #endif // V8_TARGET_ARCH_ARM 4585 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/apinatives.js ('k') | src/array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698