Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 12385074: Remove WebCompositorSupport::initialize/shutdown dependency from webkit_support::CreateLayerTreeView (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, boliu
Visibility:
Public.

Description

Remove WebCompositorSupport::initialize/shutdown dependency from webkit_support::CreateLayerTreeView webkit_support::CreateLayerTreeView is used by WebViewHost to construct compositor instances for DumpRenderTree to use in layout tests. This code creates and manages the thread used for compositor (in TestShell) and can pass it directly into the Create..() calls without needing to register it on WebCompositorSupport. This is closer to what the production code (in content::RenderWidgetCompositor) does. This adds a new entry point where the caller specifies the thread. After this lands and rolls into WebKit, I'll migrate WebViewHost to call the new function and after that rolls into Chromium remove these deprecated versions along with WebCompositorSupport::initialize/shutdown. R=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185963

Patch Set 1 #

Patch Set 2 : test_webkit_platform_support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -25 lines) Patch
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.h View 2 chunks +2 lines, -7 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.h View 2 chunks +12 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 3 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
Gets rid of some static state and tightens up an interface. Woohoo!
7 years, 9 months ago (2013-03-04 06:16:19 UTC) #1
enne (OOO)
lgtm
7 years, 9 months ago (2013-03-04 18:15:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12385074/6
7 years, 9 months ago (2013-03-04 18:17:43 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-04 20:35:50 UTC) #4
Message was sent while issue was closed.
Change committed as 185963

Powered by Google App Engine
This is Rietveld 408576698