src/x64/code-stubs-x64.cc - Issue 12385046: Fix cast warning on Win32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 12385046: Fix cast warning on Win32 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 23f9603634e58167e5f8f96f9b315ed91b955798..638e23dbd028f6392808a83df3b4a25da6436853 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -5902,14 +5902,14 @@ void ICCompareStub::GenerateUniqueNames(MacroAssembler* masm) {

Label succeed1;

__ testb(tmp1, Immediate(kIsInternalizedMask));

__ j(not_zero, &succeed1, Label::kNear);

- __ cmpb(tmp1, Immediate(static_cast<int8_t>(SYMBOL_TYPE)));

+ __ cmpb(tmp1, Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));

__ j(not_equal, &miss, Label::kNear);

__ bind(&succeed1);

Label succeed2;

__ testb(tmp2, Immediate(kIsInternalizedMask));

__ j(not_zero, &succeed2, Label::kNear);

- __ cmpb(tmp2, Immediate(static_cast<int8_t>(SYMBOL_TYPE)));

+ __ cmpb(tmp2, Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));

__ j(not_equal, &miss, Label::kNear);

__ bind(&succeed2);

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »