Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/x64/code-stubs-x64.cc

Issue 12385046: Fix cast warning on Win32 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5884 matching lines...) Expand 10 before | Expand all | Expand 10 after
5895 // types loaded in tmp1 and tmp2. 5895 // types loaded in tmp1 and tmp2.
5896 STATIC_ASSERT(kInternalizedTag != 0); 5896 STATIC_ASSERT(kInternalizedTag != 0);
5897 __ movq(tmp1, FieldOperand(left, HeapObject::kMapOffset)); 5897 __ movq(tmp1, FieldOperand(left, HeapObject::kMapOffset));
5898 __ movq(tmp2, FieldOperand(right, HeapObject::kMapOffset)); 5898 __ movq(tmp2, FieldOperand(right, HeapObject::kMapOffset));
5899 __ movzxbq(tmp1, FieldOperand(tmp1, Map::kInstanceTypeOffset)); 5899 __ movzxbq(tmp1, FieldOperand(tmp1, Map::kInstanceTypeOffset));
5900 __ movzxbq(tmp2, FieldOperand(tmp2, Map::kInstanceTypeOffset)); 5900 __ movzxbq(tmp2, FieldOperand(tmp2, Map::kInstanceTypeOffset));
5901 5901
5902 Label succeed1; 5902 Label succeed1;
5903 __ testb(tmp1, Immediate(kIsInternalizedMask)); 5903 __ testb(tmp1, Immediate(kIsInternalizedMask));
5904 __ j(not_zero, &succeed1, Label::kNear); 5904 __ j(not_zero, &succeed1, Label::kNear);
5905 __ cmpb(tmp1, Immediate(static_cast<int8_t>(SYMBOL_TYPE))); 5905 __ cmpb(tmp1, Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
5906 __ j(not_equal, &miss, Label::kNear); 5906 __ j(not_equal, &miss, Label::kNear);
5907 __ bind(&succeed1); 5907 __ bind(&succeed1);
5908 5908
5909 Label succeed2; 5909 Label succeed2;
5910 __ testb(tmp2, Immediate(kIsInternalizedMask)); 5910 __ testb(tmp2, Immediate(kIsInternalizedMask));
5911 __ j(not_zero, &succeed2, Label::kNear); 5911 __ j(not_zero, &succeed2, Label::kNear);
5912 __ cmpb(tmp2, Immediate(static_cast<int8_t>(SYMBOL_TYPE))); 5912 __ cmpb(tmp2, Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
5913 __ j(not_equal, &miss, Label::kNear); 5913 __ j(not_equal, &miss, Label::kNear);
5914 __ bind(&succeed2); 5914 __ bind(&succeed2);
5915 5915
5916 // Unique names are compared by identity. 5916 // Unique names are compared by identity.
5917 Label done; 5917 Label done;
5918 __ cmpq(left, right); 5918 __ cmpq(left, right);
5919 // Make sure rax is non-zero. At this point input operands are 5919 // Make sure rax is non-zero. At this point input operands are
5920 // guaranteed to be non-zero. 5920 // guaranteed to be non-zero.
5921 ASSERT(right.is(rax)); 5921 ASSERT(right.is(rax));
5922 __ j(not_equal, &done, Label::kNear); 5922 __ j(not_equal, &done, Label::kNear);
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
6750 #endif 6750 #endif
6751 6751
6752 __ Ret(); 6752 __ Ret();
6753 } 6753 }
6754 6754
6755 #undef __ 6755 #undef __
6756 6756
6757 } } // namespace v8::internal 6757 } } // namespace v8::internal
6758 6758
6759 #endif // V8_TARGET_ARCH_X64 6759 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698