Reland "SkPDF: Annotations are clipped by canvas clip stack."

Reland "SkPDF: Annotations are clipped by canvas clip stack."

Original patch was created by halcanary@google.com, and was reverted
because it triggered crbug.com/503541.

This patch fixes a bug in the original patch about clip path
transformation.

> Also, remove some SkPDFDevice functions.
> Will fix this GM: http://crrev.com/1159273003
> BUG=skia:3872
> Review URL: https://codereview.chromium.org/1148263005

BUG=skia:3872
BUG=503514
Committed: https://skia.googlesource.com/skia/+/d76665da1c93372720506ce7763cc810223ee9ee

[Xianzhu, 2015-07-16 21:49:26]

wangxianzhu@chromium.org changed reviewers:
+ halcanary@chromium.org, tomhudson@chromium.org

[tomhudson, 2015-07-17 12:23:20]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-07-17 12:23:20]

tomhudson@google.com changed required reviewers:
+ halcanary@chromium.org

[tomhudson, 2015-07-17 12:23:21]

LGTM but needs Hal's attention.

[hal.canary, 2015-07-17 15:06:48]

halcanary@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2015-07-17 15:06:49]

Looks good to land, but can we add a GM that tests this?

That is:  modify gm/annotated_text.cpp so that it fails when
"clip.transform(initialTransform)" is missing but works when it isn't,

[Xianzhu, 2015-07-17 16:53:03]

On 2015/07/17 15:06:49, Hal Canary wrote:
> Looks good to land, but can we add a GM that tests this?
> 
> That is:  modify gm/annotated_text.cpp so that it fails when
> "clip.transform(initialTransform)" is missing but works when it isn't,

I'm trying to add a test but have the following questions:
- Where is the expected result?
- How can I let the canvas use a SkPDFDevice with initialTransform?

[hal.canary, 2015-07-17 17:13:27]

On 2015/07/17 16:53:03, Xianzhu wrote:
> On 2015/07/17 15:06:49, Hal Canary wrote:
> > Looks good to land, but can we add a GM that tests this?
> > 
> > That is:  modify gm/annotated_text.cpp so that it fails when
> > "clip.transform(initialTransform)" is missing but works when it isn't,
> 
> I'm trying to add a test but have the following questions:
> - Where is the expected result?
> - How can I let the canvas use a SkPDFDevice with initialTransform?

Good question.  We don't have expected results.  I'll go to
http://gold.skia.org/ and triage new images as they come in.  We can verify
manually that the 

    out/Debug/dm -m annotated_text -w /tmp --config pdf
    google-chrome /tmp/pdf/gm/annotated_text.pdf

The only initialTransforms that are ever created are the identity matrix and the
vertical-flip matrix:

    ( 1.0  0.0  0.0
      0.0 -1.0  HEIGHT
      0.0  0.0  1.0    )

[Xianzhu, 2015-07-17 17:55:37]

On 2015/07/17 17:13:27, Hal Canary wrote:
> On 2015/07/17 16:53:03, Xianzhu wrote:
> > On 2015/07/17 15:06:49, Hal Canary wrote:
> > > Looks good to land, but can we add a GM that tests this?
> > > 
> > > That is:  modify gm/annotated_text.cpp so that it fails when
> > > "clip.transform(initialTransform)" is missing but works when it isn't,
> > 
> > I'm trying to add a test but have the following questions:
> > - Where is the expected result?
> > - How can I let the canvas use a SkPDFDevice with initialTransform?
> 
> Good question.  We don't have expected results.  I'll go to
> http://gold.skia.org/ and triage new images as they come in.  We can verify
> manually that the 
> 
>     out/Debug/dm -m annotated_text -w /tmp --config pdf
>     google-chrome /tmp/pdf/gm/annotated_text.pdf
> 
> The only initialTransforms that are ever created are the identity matrix and
the
> vertical-flip matrix:
> 
>     ( 1.0  0.0  0.0
>       0.0 -1.0  HEIGHT
>       0.0  0.0  1.0    )

Done. Ptal.

[hal.canary, 2015-07-17 18:05:51]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-07-17 18:05:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1238503007/#ps40001
(title: "Modify gm to reproduce the bug")

[hal.canary, 2015-07-17 18:06:02]

lgtm

[commit-bot: I haz the power, 2015-07-17 18:06:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238503007/40001

[commit-bot: I haz the power, 2015-07-17 18:06:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-07-18 00:06 UTC

[hal.canary, 2015-07-17 19:11:57]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-07-17 19:12:02]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-07-17 19:12:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238503007/40001

[commit-bot: I haz the power, 2015-07-18 00:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-18 00:06:09]

All required reviewers (with asterisk prefixes) have not yet approved this CL.

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[Xianzhu, 2015-07-18 00:22:29]

wangxianzhu@chromium.org changed reviewers:
- halcanary@chromium.org

[Xianzhu, 2015-07-18 00:22:29]

wangxianzhu@chromium.org changed required reviewers:
- halcanary@chromium.org

[Xianzhu, 2015-07-18 00:22:35]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-07-18 00:22:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238503007/40001

[Xianzhu, 2015-07-18 00:22:52]

wangxianzhu@chromium.org changed reviewers:
- tomhudson@chromium.org

[commit-bot: I haz the power, 2015-07-18 00:23:19]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d76665da1c93372720506ce7763cc810223ee9ee

[Bernhard Bauer, 2015-07-20 08:42:05]

You probably want BUG=503541 😃