Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1148263005: SkPDF: Annotations are clipped by canvas clip stack. (Closed)

Created:
5 years, 6 months ago by hal.canary
Modified:
5 years, 6 months ago
Reviewers:
tomhudson, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Annotations are clipped by canvas clip stack. Also, remove some SkPDFDevice functions. Will fix this GM: http://crrev.com/1159273003 BUG=skia:3872 Committed: https://skia.googlesource.com/skia/+/eee0e4e9d343d8b6c5ae2da7f17196f00d8859bc

Patch Set 1 #

Patch Set 2 : 2015-06-04 (Thursday) 10:39:57 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -115 lines) Patch
M src/pdf/SkPDFDevice.h View 1 chunk +1 line, -9 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 6 chunks +113 lines, -106 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hal.canary
5 years, 6 months ago (2015-06-02 22:34:14 UTC) #2
reed1
lets land the GM first, so we can play with it and load its pdf ...
5 years, 6 months ago (2015-06-04 14:03:31 UTC) #4
hal.canary
On 2015/06/04 14:03:31, reed1 wrote: > lets land the GM first, so we can play ...
5 years, 6 months ago (2015-06-04 14:40:31 UTC) #5
tomhudson
lgtm
5 years, 6 months ago (2015-06-11 21:23:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148263005/20001
5 years, 6 months ago (2015-06-14 18:00:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/eee0e4e9d343d8b6c5ae2da7f17196f00d8859bc
5 years, 6 months ago (2015-06-14 18:05:02 UTC) #9
hal.canary
5 years, 6 months ago (2015-06-23 17:52:29 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1200193003/ by halcanary@google.com.

The reason for reverting is: http://crbug.com/503541.

Powered by Google App Engine
This is Rietveld 408576698