Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1238483003: Revert of Redirect the MessageLoop's task runner to the renderer scheduler (Closed)

Created:
5 years, 5 months ago by Raymond Toy
Modified:
5 years, 5 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dcheng, aandrey+blink_chromium.org, ben+mojo_chromium.org, tim+watch_chromium.org, nona+watch_chromium.org, kalyank, mlamouri+watch-content_chromium.org, mikhal+watch_chromium.org, pam+watch_chromium.org, chirantan+watch_chromium.org, maniscalco+watch_chromium.org, avayvod+watch_chromium.org, estade+watch_chromium.org, wjia+watch_chromium.org, pfeldman, vandebo (ex-Chrome), viettrungluu+watch_chromium.org, erikwright (departed), gavinp+memory_chromium.org, sievers+watch_chromium.org, kinuko+watch, mlamouri+watch-geolocation_chromium.org, Aaron Boodman, lcwu+watch_chromium.org, jam, eme-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, Greg Billock, jsbell+serviceworker_chromium.org, penghuang+watch_chromium.org, nhiroki, asvitkine+watch_chromium.org, Michael van Ouwerkerk, gunsch+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, hclam+watch_chromium.org, michaelpg+watch-options_chromium.org, Lei Zhang, serviceworker-reviews, yurys, horo+watch_chromium.org, yusukes+watch_chromium.org, zea+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, yukishiino+watch_chromium.org, dgrogan, tracing+reviews_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, pvalenzuela+watch_chromium.org, dzhioev+watch_chromium.org, abarth-chromium, hguihot+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, erikwright+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, oshima+watch_chromium.org, piman+watch_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, tommycli, cmumford, James Su, kinuko+fileapi, davemoore+watch_chromium.org, qsr+mojo_chromium.org, tzik, posciak+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, jdduke+watch_chromium.org, jbauman+watch_chromium.org, chromoting-reviews_chromium.org, hubbe+watch_chromium.org, dbeam+watch-options_chromium.org, cc-bugs_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, danakj+watch_chromium.org, rouslan+autofillwatch_chromium.org, zork+watch_chromium.org, michaeln, Ian Vollick, mcasas+watch_chromium.org, pwestin+watch_google.com, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Redirect the MessageLoop's task runner to the renderer scheduler (patchset #11 id:220001 of https://codereview.chromium.org/987193002/) Reason for revert: Speculatively reverting. It seems to be causing flakiness on the decodeOnOtherThread test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=decodeOnOtherThread Original issue's description: > Redirect the MessageLoop's task runner to the renderer scheduler > > Configure MessageLoop::task_runner() to post tasks through the scheduler to ensure consistent task ordering. > > BUG=465354 > > Committed: https://crrev.com/f14dd762c01730a81d4a94b64ceba42eaad2d5f2 > Cr-Commit-Position: refs/heads/master@{#338706} TBR=alexclarke@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465354 Committed: https://crrev.com/70d1a346ddf711d2dc3261b607b375c629888f8a Cr-Commit-Position: refs/heads/master@{#338736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -456 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M components/scheduler/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/scheduler/child/idle_helper_unittest.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M components/scheduler/child/nestable_task_runner_for_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/scheduler/child/nestable_task_runner_for_test.cc View 1 chunk +5 lines, -1 line 0 comments Download
M components/scheduler/child/scheduler_helper.h View 3 chunks +7 lines, -7 lines 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M components/scheduler/child/scheduler_helper_unittest.cc View 4 chunks +6 lines, -12 lines 0 comments Download
A components/scheduler/child/scheduler_message_loop_delegate.h View 1 chunk +48 lines, -0 lines 0 comments Download
A components/scheduler/child/scheduler_message_loop_delegate.cc View 1 chunk +56 lines, -0 lines 0 comments Download
D components/scheduler/child/scheduler_task_runner_delegate.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/scheduler/child/scheduler_task_runner_delegate_for_test.h View 1 chunk +0 lines, -55 lines 0 comments Download
D components/scheduler/child/scheduler_task_runner_delegate_for_test.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D components/scheduler/child/scheduler_task_runner_delegate_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/scheduler/child/scheduler_task_runner_delegate_impl.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D components/scheduler/child/scheduler_task_runner_delegate_impl_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M components/scheduler/child/task_queue_manager_perftest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/scheduler/child/task_queue_manager_unittest.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M components/scheduler/child/worker_scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/scheduler/child/worker_scheduler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/worker_scheduler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/worker_scheduler_impl_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +2 lines, -3 lines 0 comments Download
M components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h View 3 chunks +3 lines, -10 lines 0 comments Download
M components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc View 3 chunks +4 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raymond Toy
Created Revert of Redirect the MessageLoop's task runner to the renderer scheduler
5 years, 5 months ago (2015-07-14 21:11:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238483003/1
5 years, 5 months ago (2015-07-14 21:11:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 21:14:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/70d1a346ddf711d2dc3261b607b375c629888f8a Cr-Commit-Position: refs/heads/master@{#338736}
5 years, 5 months ago (2015-07-14 21:15:11 UTC) #4
Noel Gordon
5 years, 5 months ago (2015-07-15 03:07:52 UTC) #5
Message was sent while issue was closed.
The decoder test recovered after this revert, FTR.

Powered by Google App Engine
This is Rietveld 408576698