Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: components/scheduler/child/task_queue_manager_unittest.cc

Issue 1238483003: Revert of Redirect the MessageLoop's task runner to the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/child/task_queue_manager.h" 5 #include "components/scheduler/child/task_queue_manager.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/single_thread_task_runner.h" 8 #include "base/single_thread_task_runner.h"
9 #include "base/test/simple_test_tick_clock.h" 9 #include "base/test/simple_test_tick_clock.h"
10 #include "base/threading/thread.h" 10 #include "base/threading/thread.h"
11 #include "cc/test/ordered_simple_task_runner.h" 11 #include "cc/test/ordered_simple_task_runner.h"
12 #include "components/scheduler/child/nestable_task_runner_for_test.h" 12 #include "components/scheduler/child/nestable_task_runner_for_test.h"
13 #include "components/scheduler/child/scheduler_task_runner_delegate_impl.h" 13 #include "components/scheduler/child/scheduler_message_loop_delegate.h"
14 #include "components/scheduler/child/task_queue_selector.h" 14 #include "components/scheduler/child/task_queue_selector.h"
15 #include "components/scheduler/child/test_time_source.h" 15 #include "components/scheduler/child/test_time_source.h"
16 #include "components/scheduler/test/test_always_fail_time_source.h" 16 #include "components/scheduler/test/test_always_fail_time_source.h"
17 #include "testing/gmock/include/gmock/gmock.h" 17 #include "testing/gmock/include/gmock/gmock.h"
18 18
19 using testing::ElementsAre; 19 using testing::ElementsAre;
20 using testing::_; 20 using testing::_;
21 21
22 namespace scheduler { 22 namespace scheduler {
23 namespace { 23 namespace {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 enum class SelectorType { 126 enum class SelectorType {
127 Automatic, 127 Automatic,
128 Explicit, 128 Explicit,
129 }; 129 };
130 130
131 void Initialize(size_t num_queues, SelectorType type) { 131 void Initialize(size_t num_queues, SelectorType type) {
132 now_src_.reset(new base::SimpleTestTickClock()); 132 now_src_.reset(new base::SimpleTestTickClock());
133 now_src_->Advance(base::TimeDelta::FromMicroseconds(1000)); 133 now_src_->Advance(base::TimeDelta::FromMicroseconds(1000));
134 test_task_runner_ = make_scoped_refptr( 134 test_task_runner_ = make_scoped_refptr(
135 new cc::OrderedSimpleTaskRunner(now_src_.get(), false)); 135 new cc::OrderedSimpleTaskRunner(now_src_.get(), false));
136 main_task_runner_ =
137 NestableTaskRunnerForTest::Create(test_task_runner_.get());
138 selector_ = make_scoped_ptr(createSelectorForTest(type)); 136 selector_ = make_scoped_ptr(createSelectorForTest(type));
139 manager_ = make_scoped_ptr( 137 manager_ = make_scoped_ptr(new TaskQueueManager(
140 new TaskQueueManager(num_queues, main_task_runner_, selector_.get(), 138 num_queues, NestableTaskRunnerForTest::Create(test_task_runner_.get()),
141 "test.scheduler", "test.scheduler.debug")); 139 selector_.get(), "test.scheduler", "test.scheduler.debug"));
142 manager_->SetTimeSourceForTesting( 140 manager_->SetTimeSourceForTesting(
143 make_scoped_ptr(new TestTimeSource(now_src_.get()))); 141 make_scoped_ptr(new TestTimeSource(now_src_.get())));
144 142
145 EXPECT_EQ(num_queues, selector_->work_queues().size()); 143 EXPECT_EQ(num_queues, selector_->work_queues().size());
146 } 144 }
147 145
148 void InitializeWithRealMessageLoop(size_t num_queues, SelectorType type) { 146 void InitializeWithRealMessageLoop(size_t num_queues, SelectorType type) {
149 message_loop_.reset(new base::MessageLoop()); 147 message_loop_.reset(new base::MessageLoop());
150 selector_ = make_scoped_ptr(createSelectorForTest(type)); 148 selector_ = make_scoped_ptr(createSelectorForTest(type));
151 manager_ = make_scoped_ptr(new TaskQueueManager( 149 manager_ = make_scoped_ptr(new TaskQueueManager(
152 num_queues, 150 num_queues, SchedulerMessageLoopDelegate::Create(message_loop_.get()),
153 SchedulerTaskRunnerDelegateImpl::Create(message_loop_.get()),
154 selector_.get(), "test.scheduler", "test.scheduler.debug")); 151 selector_.get(), "test.scheduler", "test.scheduler.debug"));
155 EXPECT_EQ(num_queues, selector_->work_queues().size()); 152 EXPECT_EQ(num_queues, selector_->work_queues().size());
156 } 153 }
157 154
158 SelectorForTest* createSelectorForTest(SelectorType type) { 155 SelectorForTest* createSelectorForTest(SelectorType type) {
159 switch (type) { 156 switch (type) {
160 case SelectorType::Automatic: 157 case SelectorType::Automatic:
161 return new AutomaticSelectorForTest(); 158 return new AutomaticSelectorForTest();
162 159
163 case SelectorType::Explicit: 160 case SelectorType::Explicit:
(...skipping 20 matching lines...) Expand all
184 &TaskQueueManager::PumpPolicyToString); 181 &TaskQueueManager::PumpPolicyToString);
185 } 182 }
186 183
187 static void CheckAllWakeupPolicyToString() { 184 static void CheckAllWakeupPolicyToString() {
188 CallForEachEnumValue<TaskQueueManager::WakeupPolicy>( 185 CallForEachEnumValue<TaskQueueManager::WakeupPolicy>(
189 TaskQueueManager::WakeupPolicy::FIRST_WAKEUP_POLICY, 186 TaskQueueManager::WakeupPolicy::FIRST_WAKEUP_POLICY,
190 TaskQueueManager::WakeupPolicy::WAKEUP_POLICY_COUNT, 187 TaskQueueManager::WakeupPolicy::WAKEUP_POLICY_COUNT,
191 &TaskQueueManager::WakeupPolicyToString); 188 &TaskQueueManager::WakeupPolicyToString);
192 } 189 }
193 190
194 scoped_ptr<base::MessageLoop> message_loop_;
195 scoped_ptr<base::SimpleTestTickClock> now_src_; 191 scoped_ptr<base::SimpleTestTickClock> now_src_;
196 scoped_refptr<NestableTaskRunnerForTest> main_task_runner_;
197 scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner_; 192 scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner_;
198 scoped_ptr<SelectorForTest> selector_; 193 scoped_ptr<SelectorForTest> selector_;
199 scoped_ptr<TaskQueueManager> manager_; 194 scoped_ptr<TaskQueueManager> manager_;
195 scoped_ptr<base::MessageLoop> message_loop_;
200 }; 196 };
201 197
202 void PostFromNestedRunloop(base::MessageLoop* message_loop, 198 void PostFromNestedRunloop(base::MessageLoop* message_loop,
203 base::SingleThreadTaskRunner* runner, 199 base::SingleThreadTaskRunner* runner,
204 std::vector<std::pair<base::Closure, bool>>* tasks) { 200 std::vector<std::pair<base::Closure, bool>>* tasks) {
205 base::MessageLoop::ScopedNestableTaskAllower allow(message_loop); 201 base::MessageLoop::ScopedNestableTaskAllower allow(message_loop);
206 for (std::pair<base::Closure, bool>& pair : *tasks) { 202 for (std::pair<base::Closure, bool>& pair : *tasks) {
207 if (pair.second) { 203 if (pair.second) {
208 runner->PostTask(FROM_HERE, pair.first); 204 runner->PostTask(FROM_HERE, pair.first);
209 } else { 205 } else {
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1295 runners[1]->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order), 1291 runners[1]->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order),
1296 delay2); 1292 delay2);
1297 1293
1298 now_src_->Advance(delay1 * 2); 1294 now_src_->Advance(delay1 * 2);
1299 test_task_runner_->RunUntilIdle(); 1295 test_task_runner_->RunUntilIdle();
1300 1296
1301 EXPECT_THAT(run_order, ElementsAre(2, 1)); 1297 EXPECT_THAT(run_order, ElementsAre(2, 1));
1302 } 1298 }
1303 1299
1304 } // namespace scheduler 1300 } // namespace scheduler
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698