Added ConnectionTimeObserver to calculate the times to authenticate and connect.

remoting/protocol/connection_to_host_impl.cc

Index: remoting/protocol/connection_to_host_impl.cc
diff --git a/remoting/protocol/connection_to_host_impl.cc b/remoting/protocol/connection_to_host_impl.cc
index f4cef0c125c8554833cd9af19595f8ff2681f9a8..6066f57508881010e9fa5b497463d9d3a7f50eba 100644
--- a/remoting/protocol/connection_to_host_impl.cc
+++ b/remoting/protocol/connection_to_host_impl.cc
@@ -22,6 +22,10 @@
 #include "remoting/protocol/transport.h"
 #include "remoting/protocol/video_stub.h"
 
+#define RETURN_STRING_LITERAL(x) \
+case x: \
+return #x;
+
 namespace remoting {
 namespace protocol {
 
@@ -299,5 +303,37 @@ void ConnectionToHostImpl::SetState(State state, ErrorCode error) {
   }
 }
 
+const char* ConnectionStateToString(ConnectionToHost::State state) {
+  switch (state) {
+    RETURN_STRING_LITERAL(ConnectionToHost::INITIALIZING);
+    RETURN_STRING_LITERAL(ConnectionToHost::CONNECTING);
+    RETURN_STRING_LITERAL(ConnectionToHost::AUTHENTICATED);
+    RETURN_STRING_LITERAL(ConnectionToHost::CONNECTED);
+    RETURN_STRING_LITERAL(ConnectionToHost::CLOSED);
+    RETURN_STRING_LITERAL(ConnectionToHost::FAILED);
+    default:

[Sergey Ulanov, 2015/07/30 21:00:42]

nit: default case should be marked as NOTREACHED() as we never expect this (and
you don't need the LOG(ERROR))
move default case out of the switch() statement, i.e.
 switch (state) {
  ..
 }
 NOTREACHED();
 return nullptr;

This way the compiler will warn about missing cases when a new value is added in
the enum.

[tonychun, 2015/07/30 21:43:16]

Done.

+      LOG(ERROR) << "Unknown connection state: '" << state << "'";
+      return "ConnectionToHost::UNKNOWN";
+  }
+}
+
+const char* ErrorCodeToString(ErrorCode error) {

[Sergey Ulanov, 2015/07/30 21:00:42]

This function is declared in remoting/protocol/errors.h , so it doesn't belong
to this file. Please create errors.cc and move this function there.

[tonychun, 2015/07/30 21:43:16]

Done.

+  switch (error) {
+    RETURN_STRING_LITERAL(OK);
+    RETURN_STRING_LITERAL(PEER_IS_OFFLINE);
+    RETURN_STRING_LITERAL(SESSION_REJECTED);
+    RETURN_STRING_LITERAL(INCOMPATIBLE_PROTOCOL);
+    RETURN_STRING_LITERAL(AUTHENTICATION_FAILED);
+    RETURN_STRING_LITERAL(CHANNEL_CONNECTION_ERROR);
+    RETURN_STRING_LITERAL(SIGNALING_ERROR);
+    RETURN_STRING_LITERAL(SIGNALING_TIMEOUT);
+    RETURN_STRING_LITERAL(HOST_OVERLOAD);
+    RETURN_STRING_LITERAL(UNKNOWN_ERROR);
+    default:

[Sergey Ulanov, 2015/07/30 21:00:42]

same as the previous comment about default case.

[tonychun, 2015/07/30 21:43:16]

Done.

+      LOG(ERROR) << "Unknown error: '" << error << "'";
+      return "UNKNOWN ERROR";
+  }
+}
+
 }  // namespace protocol
 }  // namespace remoting