Added ConnectionTimeObserver to calculate the times to authenticate and connect.

remoting/protocol/connection_to_host_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/connection_to_host_impl.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/location.h"
 #include "remoting/base/constants.h"
 #include "remoting/protocol/audio_reader.h"
 #include "remoting/protocol/audio_stub.h"
 #include "remoting/protocol/auth_util.h"
 #include "remoting/protocol/authenticator.h"
 #include "remoting/protocol/client_control_dispatcher.h"
 #include "remoting/protocol/client_event_dispatcher.h"
 #include "remoting/protocol/client_stub.h"
 #include "remoting/protocol/client_video_dispatcher.h"
 #include "remoting/protocol/clipboard_stub.h"
 #include "remoting/protocol/errors.h"
 #include "remoting/protocol/jingle_session_manager.h"
 #include "remoting/protocol/transport.h"
 #include "remoting/protocol/video_stub.h"
 
+#define RETURN_STRING_LITERAL(x) \
+case x: \
+return #x;
+
 namespace remoting {
 namespace protocol {
 
 ConnectionToHostImpl::ConnectionToHostImpl()
     : event_callback_(nullptr),
       client_stub_(nullptr),
       clipboard_stub_(nullptr),
       audio_stub_(nullptr),
       signal_strategy_(nullptr),
       state_(INITIALIZING),
@@ skipping 257 matching lines @@
   // |error| should be specified only when |state| is set to FAILED.
   DCHECK(state == FAILED || error == OK);
 
   if (state != state_) {
     state_ = state;
     error_ = error;
     event_callback_->OnConnectionState(state_, error_);
   }
 }
 
+const char* ConnectionStateToString(ConnectionToHost::State state) {
+  switch (state) {
+    RETURN_STRING_LITERAL(ConnectionToHost::INITIALIZING);
+    RETURN_STRING_LITERAL(ConnectionToHost::CONNECTING);
+    RETURN_STRING_LITERAL(ConnectionToHost::AUTHENTICATED);
+    RETURN_STRING_LITERAL(ConnectionToHost::CONNECTED);
+    RETURN_STRING_LITERAL(ConnectionToHost::CLOSED);
+    RETURN_STRING_LITERAL(ConnectionToHost::FAILED);
+    default:

[Sergey Ulanov, 2015/07/30 21:00:42]

nit: default case should be marked as NOTREACHED() as we never expect this (and
you don't need the LOG(ERROR))
move default case out of the switch() statement, i.e.
 switch (state) {
  ..
 }
 NOTREACHED();
 return nullptr;

This way the compiler will warn about missing cases when a new value is added in
the enum.

[tonychun, 2015/07/30 21:43:16]

Done.

+      LOG(ERROR) << "Unknown connection state: '" << state << "'";
+      return "ConnectionToHost::UNKNOWN";
+  }
+}
+
+const char* ErrorCodeToString(ErrorCode error) {

[Sergey Ulanov, 2015/07/30 21:00:42]

This function is declared in remoting/protocol/errors.h , so it doesn't belong
to this file. Please create errors.cc and move this function there.

[tonychun, 2015/07/30 21:43:16]

Done.

+  switch (error) {
+    RETURN_STRING_LITERAL(OK);
+    RETURN_STRING_LITERAL(PEER_IS_OFFLINE);
+    RETURN_STRING_LITERAL(SESSION_REJECTED);
+    RETURN_STRING_LITERAL(INCOMPATIBLE_PROTOCOL);
+    RETURN_STRING_LITERAL(AUTHENTICATION_FAILED);
+    RETURN_STRING_LITERAL(CHANNEL_CONNECTION_ERROR);
+    RETURN_STRING_LITERAL(SIGNALING_ERROR);
+    RETURN_STRING_LITERAL(SIGNALING_TIMEOUT);
+    RETURN_STRING_LITERAL(HOST_OVERLOAD);
+    RETURN_STRING_LITERAL(UNKNOWN_ERROR);
+    default:

[Sergey Ulanov, 2015/07/30 21:00:42]

same as the previous comment about default case.

[tonychun, 2015/07/30 21:43:16]

Done.

+      LOG(ERROR) << "Unknown error: '" << error << "'";
+      return "UNKNOWN ERROR";
+  }
+}
+
 }  // namespace protocol
 }  // namespace remoting