Added ConnectionTimeObserver to calculate the times to authenticate and connect.

remoting/test/test_chromoting_client.cc

Index: remoting/test/test_chromoting_client.cc
diff --git a/remoting/test/test_chromoting_client.cc b/remoting/test/test_chromoting_client.cc
index d838ba3a7986d363609e23777dedede28d182e5f..3c101e4f4e3698f8307152a991b20ead1806ffcb 100644
--- a/remoting/test/test_chromoting_client.cc
+++ b/remoting/test/test_chromoting_client.cc
@@ -60,33 +60,6 @@ void FetchSecret(
   secret_fetched_callback.Run(client_secret);
 }
 
-const char* ConnectionStateToFriendlyString(
-    remoting::protocol::ConnectionToHost::State state) {
-  switch (state) {
-    case remoting::protocol::ConnectionToHost::INITIALIZING:
-      return "INITIALIZING";
-
-    case remoting::protocol::ConnectionToHost::CONNECTING:
-      return "CONNECTING";
-
-    case remoting::protocol::ConnectionToHost::AUTHENTICATED:
-      return "AUTHENTICATED";
-
-    case remoting::protocol::ConnectionToHost::CONNECTED:
-      return "CONNECTED";
-
-    case remoting::protocol::ConnectionToHost::CLOSED:
-      return "CLOSED";
-
-    case remoting::protocol::ConnectionToHost::FAILED:
-      return "FAILED";
-
-    default:
-      LOG(ERROR) << "Unknown connection state: '" << state << "'";
-      return "UNKNOWN";
-  }
-}
-
 const char* ProtocolErrorToFriendlyString(

[joedow, 2015/07/27 21:45:45]

Per my previous comment about adding a pretty printing helper, it's probably a
good idea to move these into the same file as the enum values are defined so
anyone who includes the file (i.e. interested in the values) can print nice
error messages.

[tonychun, 2015/07/28 17:53:45]

Done.

     remoting::protocol::ErrorCode error_code) {
   switch (error_code) {
@@ -148,6 +121,34 @@ TestChromotingClient::~TestChromotingClient() {
   EndConnection();
 }
 
+// static

[joedow, 2015/07/27 21:45:44]

please remove comment, it isn't needed in the impl file

[tonychun, 2015/07/28 17:53:45]

Done.

+const char* TestChromotingClient::ConnectionStateToFriendlyString(
+    remoting::protocol::ConnectionToHost::State state) {
+  switch (state) {
+    case remoting::protocol::ConnectionToHost::INITIALIZING:
+      return "INITIALIZING";
+
+    case remoting::protocol::ConnectionToHost::CONNECTING:
+      return "CONNECTING";
+
+    case remoting::protocol::ConnectionToHost::AUTHENTICATED:
+      return "AUTHENTICATED";
+
+    case remoting::protocol::ConnectionToHost::CONNECTED:
+      return "CONNECTED";
+
+    case remoting::protocol::ConnectionToHost::CLOSED:
+      return "CLOSED";
+
+    case remoting::protocol::ConnectionToHost::FAILED:
+      return "FAILED";
+
+    default:
+      LOG(ERROR) << "Unknown connection state: '" << state << "'";
+      return "UNKNOWN";
+  }
+}
+
 void TestChromotingClient::StartConnection(
     const ConnectionSetupInfo& connection_setup_info) {
   // Required to establish a connection to the host.