Added ConnectionTimeObserver to calculate the times to authenticate and connect.

remoting/test/test_chromoting_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/test/test_chromoting_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 42 matching lines @@
   }
 }
 
 void FetchSecret(
     const std::string& client_secret,
     bool pairing_expected,
     const remoting::protocol::SecretFetchedCallback& secret_fetched_callback) {
   secret_fetched_callback.Run(client_secret);
 }
 
-const char* ConnectionStateToFriendlyString(
-    remoting::protocol::ConnectionToHost::State state) {
-  switch (state) {
-    case remoting::protocol::ConnectionToHost::INITIALIZING:
-      return "INITIALIZING";
-
-    case remoting::protocol::ConnectionToHost::CONNECTING:
-      return "CONNECTING";
-
-    case remoting::protocol::ConnectionToHost::AUTHENTICATED:
-      return "AUTHENTICATED";
-
-    case remoting::protocol::ConnectionToHost::CONNECTED:
-      return "CONNECTED";
-
-    case remoting::protocol::ConnectionToHost::CLOSED:
-      return "CLOSED";
-
-    case remoting::protocol::ConnectionToHost::FAILED:
-      return "FAILED";
-
-    default:
-      LOG(ERROR) << "Unknown connection state: '" << state << "'";
-      return "UNKNOWN";
-  }
-}
-
 const char* ProtocolErrorToFriendlyString(

[joedow, 2015/07/27 21:45:45]

Per my previous comment about adding a pretty printing helper, it's probably a
good idea to move these into the same file as the enum values are defined so
anyone who includes the file (i.e. interested in the values) can print nice
error messages.

[tonychun, 2015/07/28 17:53:45]

Done.

     remoting::protocol::ErrorCode error_code) {
   switch (error_code) {
     case remoting::protocol::OK:
       return "NONE";
 
     case remoting::protocol::PEER_IS_OFFLINE:
       return "PEER_IS_OFFLINE";
 
     case remoting::protocol::SESSION_REJECTED:
       return "SESSION_REJECTED";
@@ skipping 40 matching lines @@
     : video_renderer_(video_renderer.Pass()) {
   TestChromotingClient();
 }
 
 TestChromotingClient::~TestChromotingClient() {
   // Ensure any connections are closed and the members are destroyed in the
   // appropriate order.
   EndConnection();
 }
 
+// static

[joedow, 2015/07/27 21:45:44]

please remove comment, it isn't needed in the impl file

[tonychun, 2015/07/28 17:53:45]

Done.

+const char* TestChromotingClient::ConnectionStateToFriendlyString(
+    remoting::protocol::ConnectionToHost::State state) {
+  switch (state) {
+    case remoting::protocol::ConnectionToHost::INITIALIZING:
+      return "INITIALIZING";
+
+    case remoting::protocol::ConnectionToHost::CONNECTING:
+      return "CONNECTING";
+
+    case remoting::protocol::ConnectionToHost::AUTHENTICATED:
+      return "AUTHENTICATED";
+
+    case remoting::protocol::ConnectionToHost::CONNECTED:
+      return "CONNECTED";
+
+    case remoting::protocol::ConnectionToHost::CLOSED:
+      return "CLOSED";
+
+    case remoting::protocol::ConnectionToHost::FAILED:
+      return "FAILED";
+
+    default:
+      LOG(ERROR) << "Unknown connection state: '" << state << "'";
+      return "UNKNOWN";
+  }
+}
+
 void TestChromotingClient::StartConnection(
     const ConnectionSetupInfo& connection_setup_info) {
   // Required to establish a connection to the host.
   jingle_glue::JingleThreadWrapper::EnsureForCurrentMessageLoop();
 
   scoped_refptr<URLRequestContextGetter> request_context_getter;
   request_context_getter = new URLRequestContextGetter(
       base::ThreadTaskRunnerHandle::Get(),   // network_runner
       base::ThreadTaskRunnerHandle::Get());  // file_runner
 
@@ skipping 179 matching lines @@
   VLOG(1) << "TestChromotingClient::InjectClipboardEvent() Called";
 }
 
 void TestChromotingClient::SetCursorShape(
     const protocol::CursorShapeInfo& cursor_shape) {
   VLOG(1) << "TestChromotingClient::SetCursorShape() Called";
 }
 
 }  // namespace test
 }  // namespace remoting