Chromium Code Reviews Chromium Code Reviews
Issue 123833005:
Limit HTMLKeygenElement.keytype to only known values. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/dom/HTMLKeygenElement/keygen.html |
| diff --git a/LayoutTests/fast/dom/HTMLKeygenElement/keygen.html b/LayoutTests/fast/dom/HTMLKeygenElement/keygen.html |
| index 1070a24005cbd272f96e5f7125d5882034caf131..71309305d25d8d17085cf8b8a200afc0cd91d9c3 100644 |
| --- a/LayoutTests/fast/dom/HTMLKeygenElement/keygen.html |
| +++ b/LayoutTests/fast/dom/HTMLKeygenElement/keygen.html |
| @@ -1,17 +1,18 @@ |
| <!DOCTYPE html> |
| -<html> |
| -<head> |
| <script src="../../../resources/js-test.js"></script> |
| -</head> |
| -<body> |
| <keygen id="keys" /> |
| -<pre id="console"> |
| -This tests the keygen element. |
| - |
| -</pre> |
| <script> |
| +description("This tests the keygen element"); |
| + |
| var keygen = document.getElementById('keys'); |
| shouldBe('keygen.options', 'undefined'); // keygen is not a select |
| +shouldBeEqualToString('keygen.type', 'keygen'); |
| +// FIXME: the 'keytype' attribute has "rsa" as its missing value |
|
tkent
2014/01/06 23:45:24
Maybe this comment should be put after the line sh
sof
2014/01/07 09:13:10
Yes, agree. Given the clarification on crbug.com/3
|
| +// default. crbug.com/331694 |
| +shouldBeEqualToString('keygen.keytype', 'rsa'); |
| +keygen.keytype = "foo"; |
|
tkent
2014/01/06 23:45:24
it's helpful if this operation is shown in the tes
|
| +shouldBeEqualToString('keygen.keytype', ''); |
|
tkent
2014/01/06 23:45:24
You may write a test so that this test fails until
|
| +shouldBeEqualToString('keygen.getAttribute("KEYtype")', 'foo'); |
| if (window.internals) { |
| var shadow = internals.shadowRoot(keygen); |
| @@ -19,5 +20,3 @@ if (window.internals) { |
| shouldBe('internals.shadowRoot(shadow.firstChild)', 'null'); |
| } |
| </script> |
| -</body> |
| -</html> |
