LayoutTests/fast/dom/HTMLKeygenElement/keygen.html - Issue 123833005: Limit HTMLKeygenElement.keytype to only known values.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLKeygenElement/keygen.html

Issue 123833005: Limit HTMLKeygenElement.keytype to only known values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>

3 <head>

4 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

5 </head>

6 <body>

7 <keygen id="keys" />	3 <keygen id="keys" />

8 <pre id="console">	4 <script>

9 This tests the keygen element.	5 description("This tests the keygen element");

10	6

11 </pre>

12 <script>

13 var keygen = document.getElementById('keys');	7 var keygen = document.getElementById('keys');

14 shouldBe('keygen.options', 'undefined'); // keygen is not a select	8 shouldBe('keygen.options', 'undefined'); // keygen is not a select

	9 shouldBeEqualToString('keygen.type', 'keygen');

	10 // FIXME: the 'keytype' attribute has "rsa" as its missing value
	tkent 2014/01/06 23:45:24 Maybe this comment should be put after the line sh Maybe this comment should be put after the line shouldBeEqualToString('keygen.keytype', 'rsa');? sof 2014/01/07 09:13:10 Yes, agree. Given the clarification on crbug.com/3 Show quoted text On 2014/01/06 23:45:24, tkent wrote: > Maybe this comment should be put after the line > shouldBeEqualToString('keygen.keytype', 'rsa');? Yes, agree. Given the clarification on crbug.com/331694 , I will address it first & avoid having to leave behind a FIXME here.
	11 // default. crbug.com/331694

	12 shouldBeEqualToString('keygen.keytype', 'rsa');

	13 keygen.keytype = "foo";
	tkent 2014/01/06 23:45:24 it's helpful if this operation is shown in the tes it's helpful if this operation is shown in the test result. shouldBeEqualToString('keygen.keytype = 'foo'; keygen.keytype', '');
	14 shouldBeEqualToString('keygen.keytype', '');
	tkent 2014/01/06 23:45:24 You may write a test so that this test fails until You may write a test so that this test fails until crbug.com/331694 fix, and put a FAIL line to -expected.txt. shouldBeEqualToString('keygen.keytype', 'rsa'); It's up to you.
	15 shouldBeEqualToString('keygen.getAttribute("KEYtype")', 'foo');

15	16

16 if (window.internals) {	17 if (window.internals) {

17 var shadow = internals.shadowRoot(keygen);	18 var shadow = internals.shadowRoot(keygen);

18 shouldBe('shadow.firstChild.tagName', '"SELECT"');	19 shouldBe('shadow.firstChild.tagName', '"SELECT"');

19 shouldBe('internals.shadowRoot(shadow.firstChild)', 'null');	20 shouldBe('internals.shadowRoot(shadow.firstChild)', 'null');

20 }	21 }

21 </script>	22 </script>

22 </body>

23 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLKeygenElement/keygen-expected.txt » ('j') | no next file with comments »