Limit HTMLKeygenElement.keytype to only known values.

Limit HTMLKeygenElement.keytype to only known values.

The only supported value for the <keygen/> element's keytype attribute
is the keyword for the RSA state ("rsa".) Impose the required
normalization of the IDL attribute when getting its value.

R=
BUG=321862
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165027

[sof, 2014-01-06 17:30:37]

Please take a look whenever there's time.

The remaining issue for HTMLKeygenElement.keytype is how to handle the missing
value case. Added a test here, but it will be handled (one way or another) by
http://crbug.com/331694

[tkent, 2014-01-06 23:45:23]

https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
File LayoutTests/fast/dom/HTMLKeygenElement/keygen.html (right):

https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
LayoutTests/fast/dom/HTMLKeygenElement/keygen.html:10: // FIXME: the 'keytype'
attribute has "rsa" as its missing value
Maybe this comment should be put after the line
shouldBeEqualToString('keygen.keytype', 'rsa');?

https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
LayoutTests/fast/dom/HTMLKeygenElement/keygen.html:13: keygen.keytype = "foo";
it's helpful if this operation is shown in the test result.
    shouldBeEqualToString('keygen.keytype = 'foo'; keygen.keytype', '');

https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
LayoutTests/fast/dom/HTMLKeygenElement/keygen.html:14:
shouldBeEqualToString('keygen.keytype', '');
You may write a test so that this test fails until crbug.com/331694 fix, and put
a FAIL line to -expected.txt.
    shouldBeEqualToString('keygen.keytype', 'rsa');

It's up to you.

[tkent, 2014-01-06 23:45:55]

anyway, lgtm.

[sof, 2014-01-07 09:13:09]

https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
File LayoutTests/fast/dom/HTMLKeygenElement/keygen.html (right):

https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
LayoutTests/fast/dom/HTMLKeygenElement/keygen.html:10: // FIXME: the 'keytype'
attribute has "rsa" as its missing value
On 2014/01/06 23:45:24, tkent wrote:
> Maybe this comment should be put after the line
> shouldBeEqualToString('keygen.keytype', 'rsa');?

Yes, agree. Given the clarification on crbug.com/331694 , I will address it
first & avoid having to leave behind a FIXME here.

[sof, 2014-01-07 13:53:54]

On 2014/01/07 09:13:09, sof wrote:
>
https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
> File LayoutTests/fast/dom/HTMLKeygenElement/keygen.html (right):
> 
>
https://codereview.chromium.org/123833005/diff/1/LayoutTests/fast/dom/HTMLKey...
> LayoutTests/fast/dom/HTMLKeygenElement/keygen.html:10: // FIXME: the 'keytype'
> attribute has "rsa" as its missing value
> On 2014/01/06 23:45:24, tkent wrote:
> > Maybe this comment should be put after the line
> > shouldBeEqualToString('keygen.keytype', 'rsa');?
> 
> Yes, agree. Given the clarification on crbug.com/331694 , I will address it
> first & avoid having to leave behind a FIXME here.

Done; [ReflectMissing] is now made use of.

[sof, 2014-01-09 15:40:39]

tkent: time for a final peek at the added tests? :)

[tkent, 2014-01-14 00:31:38]

lgtm

[commit-bot: I haz the power, 2014-01-14 00:33:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/123833005/110001

[commit-bot: I haz the power, 2014-01-14 04:40:41]

Change committed as 165027